Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning if ModMask and per-binding modifiers overlap in potentially confusing ways #121

Open
MintDja opened this issue Jan 26, 2021 · 8 comments
Labels
Milestone

Comments

@MintDja
Copy link

MintDja commented Jan 26, 2021

At the moment, at home and at work, I use the LinuxMint 19.3 system on which everything works successfully. At the weekend I decided to try LinuhMint 20.1 XFCE at home after debian 10.
Both on one and on the other system, the filmed behavior is observed. Windows move around the hotkey, but do not resize. Regards
https://youtu.be/wGqtHBpTUak

@ssokolow
Copy link
Owner

ssokolow commented Jan 26, 2021

It's probably because you changed ModMask to include <Shift> but didn't delete or change these lines from your config file:

<Shift>KP_1 = move-to-bottom-left
<Shift>KP_2 = move-to-bottom
<Shift>KP_3 = move-to-bottom-right
<Shift>KP_4 = move-to-left
<Shift>KP_5 = move-to-center
<Shift>KP_6 = move-to-right
<Shift>KP_7 = move-to-top-left
<Shift>KP_8 = move-to-top
<Shift>KP_9 = move-to-top-right

I don't have time to double-check right now (I'm about to go to sleep), but those are probably taking precedence.

@MintDja
Copy link
Author

MintDja commented Jan 26, 2021

Yes, I changed ModMask = <Ctrl><Alt> to ModMask = <Ctrl><Shift>
Goodnight

@ssokolow
Copy link
Owner

ssokolow commented Jan 27, 2021

Does removing the <Shift>KP_* lines fix the problem?

...because it looks like it's operating as designed to me. (You specified that <Ctrl><Shift><Shift>KP_1 should be move-to-bottom-left, which is the same as <Ctrl><Shift>KP_1 since you can't set a boolean to "double true", and that's what it's doing.)

I didn't intentionally consider what would happen if you specified a ModMask and a keybinding with overlapping modifier requirements, but "obey the more specific match" behaviour seems reasonable... though I might want to have a future version of QuickTile at least print a warning if it detects that.

@MintDja
Copy link
Author

MintDja commented Jan 27, 2021

yes, the extra lines are to blame! Thank you!

@MintDja
Copy link
Author

MintDja commented Jan 27, 2021

in this case there are extra lines in the downloaded configuration file

@ssokolow
Copy link
Owner

Yes. The default configuration is to have holding down <Shift> mean "Don't resize, just move."

It's your job to remove the <Shift> lines if you add <Shift> to ModMask.

...though, as I said, now that you've made me aware of that point of confusion, I'll try to remember to add a warning to the next version.

@MintDja MintDja closed this as completed Jan 27, 2021
@ssokolow
Copy link
Owner

Actually, let's keep this open and rename it as my reminder to add that warning.

@ssokolow ssokolow reopened this Jan 27, 2021
@ssokolow ssokolow changed the title No resizing in new versions of linux Display a warning if ModMask and per-binding modifiers overlap in potentially confusing ways Jan 27, 2021
@ssokolow
Copy link
Owner

ssokolow commented Aug 6, 2023

It's looking like the solution for this will be the new config GUI I'm working on, where the hotkey editor will not have a ModMask (each binding will be exactly what you pressed to set it) and will highlight any conflicting keybindings in red.

@ssokolow ssokolow added this to the JSON Config milestone Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants