Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude config file in VS code #164

Closed
eric-burel opened this issue Jul 23, 2024 · 2 comments · Fixed by #173
Closed

Do not exclude config file in VS code #164

eric-burel opened this issue Jul 23, 2024 · 2 comments · Fixed by #173
Labels
pr-welcome Accepting pull requests for this change

Comments

@eric-burel
Copy link
Contributor

Is your feature request related to a problem?

Hi, it took me some time to figure that the project was using file exclusion in .vscode to hide the config (astro.config etc.)
The documentation mentions an astro.config file we may tweak to customize the project and I couldn't find it, and honestly started to believe TutorialKit was working with some magic I couldn't comprehend ':)

Files I see, and the VS code setting
image

Describe the solution you'd like.

Not hide the config, I'd rather see the astro config in the files in vs code to figure how TutorialKit works

Describe alternatives you've considered.

Move the config to a hidden folder so it doesn't clutter the root of the folder but can still be available, in Vulcan Next we used to have a .vn for that

Additional context

No response

@AriPerkkio AriPerkkio added the pr-welcome Accepting pull requests for this change label Jul 23, 2024
@AriPerkkio
Copy link
Member

AriPerkkio commented Jul 23, 2024

We are planning to remove whole .vscode/settings.json. It's been listed in v1 roadmap: #144

PR welcome! 🙌

{
"files.exclude": {
".astro": true,
"astro.config.ts": true,
"uno.config.ts": true,
"tsconfig.json": true,
"icons": true,
"src/env.d.ts": true,
"**/.git": true,
"**/.svn": true,
"**/.hg": true,
"**/CVS": true,
"**/.DS_Store": true,
"**/Thumbs.db": true
}
}

@eric-burel
Copy link
Contributor Author

Thanks I'll keep track of the v1 roadmap and close in the meanwhile, so far it's already working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome Accepting pull requests for this change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants