Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Terminal button should be hidden when terminal: false #300

Open
AriPerkkio opened this issue Sep 2, 2024 · 3 comments
Open

Toggle Terminal button should be hidden when terminal: false #300

AriPerkkio opened this issue Sep 2, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@AriPerkkio
Copy link
Member

Describe the bug

When terminal is disabled in metadata, the Toggle Terminal button is still visible. It just shows empty blank terminal when toggled.

Link to a StackBlitz project which shows the error

No response

Steps to reproduce

  1. Define in metadata:
---
type: lesson
title: Test
terminal: false
---
  1. Open page and click Toggle Terminal

Expected behavior

Whole Toggle Terminal button should be hidden.

Screenshots

image

Platform

  • TutorialKit version: 0.2.1

Additional context

No response

@AriPerkkio AriPerkkio added bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change labels Sep 2, 2024
@Charan167
Copy link
Contributor

Hello @AriPerkkio. I was trying to recreate this issue but it seems to be working fine. Could you please help me out?

Recording.2024-09-28.194458.3.mp4

@AriPerkkio
Copy link
Member Author

but it seems to be working fine

Great, thanks for checking this! 🙌

I'll check later if this issue is still valid. Feel free to proceed with the other issue mentioned in #343 (review).

@AriPerkkio AriPerkkio removed good first issue Good for newcomers pr-welcome Accepting pull requests for this change labels Oct 4, 2024
AriPerkkio added a commit that referenced this issue Oct 14, 2024
@AriPerkkio
Copy link
Member Author

AriPerkkio commented Oct 14, 2024

I'll check later if this issue is still valid.

Yup, this is still valid. Added failing test case at https://github.com/stackblitz/tutorialkit/tree/test/terminal-false.

Task assigned to @RonithManikonda.

tk-terminal-false.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants