Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.allowCommands should have more strict default value #302

Open
AriPerkkio opened this issue Sep 2, 2024 · 0 comments
Open

terminal.allowCommands should have more strict default value #302

AriPerkkio opened this issue Sep 2, 2024 · 0 comments
Labels
breaking changes enhancement New feature or request

Comments

@AriPerkkio
Copy link
Member

AriPerkkio commented Sep 2, 2024

Is your feature request related to a problem?

By default the terminal allows users to use any available command. In tutorials this is usually not intended experience. The lesson authors should define commands that are allowed - if any.

Describe the solution you'd like.

Let's change the default value of terminal.allowCommands from [] to something like ['ls', 'echo'].

Lesson authors should still be able to allow all possible commands by specifying terminal.allowCommands: [] in metadata.

Describe alternatives you've considered.

Recommend authors to always specify terminal.allowCommands.

Additional context

No response

@AriPerkkio AriPerkkio added enhancement New feature or request breaking changes labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant