You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The webcontainer link text customization is not enough, because this footer is also the place where we may want to include legal terms, contact info and copyrights, especially when deploying a tutorial as a completely standalone website with no other content page.
Describe the solution you'd like.
Similarly to TopBar, customizing the footer.
Describe alternatives you've considered.
Customizing "webcontainerLinkText" to feed it more content is not enough, as it will be wrapped by an anchor tag.
Additional context
I am digging the code to better understand the implementation, and maybe contribute : I see that overidable components are typed in packages/astro/src/default/env-default.d.ts, which then allows to get them from a virtual import packages/astro/src/default/components/TopBarWrapper.astro.
I think this system is fine, so it could be expanded to more components. Coupled with slots, it's really great because you only need to provide the relevant slots in your own version to keep similar content around.
The text was updated successfully, but these errors were encountered:
This is great idea! Currently we only support overriding the TopBar, but the idea was that we would extend the support for other components when requests like this come up.
To see how TopBar overriding was implemented, see:
I think it would make sense to include all these components in the footer component:
So something like:
<footer>
Some content here
<slotname="edit-page-link" />
and here
<slotname="back-link" />
here too
<slotname="next-link" />
here too
<slotname="webcontainers-link" />
and here!
</footer>
adds support for overriding the footer component, similar to the TopBar override setup. Users can now customize footer content such as legal terms, contact info, and copyrights.
this change introduces `Footer.astro` and `FooterWrapper.astro` files to allow flexible slotting of footer items, improving customization for standalone tutorial deployments
close#323
Is your feature request related to a problem?
The webcontainer link text customization is not enough, because this footer is also the place where we may want to include legal terms, contact info and copyrights, especially when deploying a tutorial as a completely standalone website with no other content page.
Describe the solution you'd like.
Similarly to TopBar, customizing the footer.
Describe alternatives you've considered.
Customizing "webcontainerLinkText" to feed it more content is not enough, as it will be wrapped by an anchor tag.
Additional context
I am digging the code to better understand the implementation, and maybe contribute : I see that overidable components are typed in
packages/astro/src/default/env-default.d.ts
, which then allows to get them from a virtual importpackages/astro/src/default/components/TopBarWrapper.astro
.I think this system is fine, so it could be expanded to more components. Coupled with slots, it's really great because you only need to provide the relevant slots in your own version to keep similar content around.
The text was updated successfully, but these errors were encountered: