From 20c7117238b58299b44876836180baf1667f1ab1 Mon Sep 17 00:00:00 2001 From: Jakub Darmach Date: Thu, 9 Oct 2025 13:49:18 +0200 Subject: [PATCH 1/3] Fix prechecks group exist check Fixes group existence assert to iterate over groups instead of group_names. --- changelogs/changelog.yaml | 5 +++++ roles/cephadm/tasks/prechecks.yml | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 0595069..4359316 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -33,3 +33,8 @@ releases: fragments: - sudo-fix.yml release_date: '2025-01-08' + 1.19.2: + changes: + bugfixes: + - prechecks - fix groups existing assertion + release date: '2025-10-09' diff --git a/roles/cephadm/tasks/prechecks.yml b/roles/cephadm/tasks/prechecks.yml index 421a3f6..1cf7204 100644 --- a/roles/cephadm/tasks/prechecks.yml +++ b/roles/cephadm/tasks/prechecks.yml @@ -1,7 +1,7 @@ --- - name: Assert that required Ansible groups exist ansible.builtin.assert: - that: "'{{ item }}' in group_names" + that: "'{{ item }}' in groups" msg: "Ansible '{{ item }}' group does not exist - please create one" loop: - ceph From 2d7000bb5069cdd6fb30ed360bc3d458ef8f79d3 Mon Sep 17 00:00:00 2001 From: Jakub Darmach Date: Thu, 9 Oct 2025 14:00:36 +0200 Subject: [PATCH 2/3] Fix changelog typo --- changelogs/changelog.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 4359316..3595028 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -37,4 +37,4 @@ releases: changes: bugfixes: - prechecks - fix groups existing assertion - release date: '2025-10-09' + release_date: '2025-10-09' From a54b6b3f6c028e3235c64b1d3e6df7ecbe505ed7 Mon Sep 17 00:00:00 2001 From: Jakub Darmach Date: Thu, 9 Oct 2025 14:05:41 +0200 Subject: [PATCH 3/3] Change groups existence check to run once --- changelogs/changelog.yaml | 1 + roles/cephadm/tasks/prechecks.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 3595028..ba43d5f 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -37,4 +37,5 @@ releases: changes: bugfixes: - prechecks - fix groups existing assertion + - prechecks - change groups existence check to run once release_date: '2025-10-09' diff --git a/roles/cephadm/tasks/prechecks.yml b/roles/cephadm/tasks/prechecks.yml index 1cf7204..a8e1de9 100644 --- a/roles/cephadm/tasks/prechecks.yml +++ b/roles/cephadm/tasks/prechecks.yml @@ -1,5 +1,6 @@ --- - name: Assert that required Ansible groups exist + run_once: true ansible.builtin.assert: that: "'{{ item }}' in groups" msg: "Ansible '{{ item }}' group does not exist - please create one"