Skip to content

Fix Gtk3Backend compiler crash #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackotter merged 3 commits into from
Jan 2, 2026
Merged

Fix Gtk3Backend compiler crash #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdf5caa
rename `Size` to `CustomWidgetSize` to fix "ambiguous reference to Si…
kaascevich Dec 30, 2025
8d83d86
Merge branch 'stackotter:main' into fix-gtkbackend-compiler-crash
kaascevich Dec 31, 2025
61683a9
fix Gtk3Backend compiler crash by renaming the `Size` type in `gtk_cu…
kaascevich Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Gtk3CustomWidgets/gtk_custom_root_widget.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void gtk_custom_root_widget_size_allocate(
root_widget->has_been_allocated = TRUE;

if (root_widget->resize_callback != NULL) {
Size size = { .width = allocation->width, .height = allocation->height };
CustomWidgetSize size = { .width = allocation->width, .height = allocation->height };
root_widget->resize_callback(root_widget->resize_callback_data, size);
}
}
Expand Down Expand Up @@ -144,7 +144,7 @@ void gtk_custom_root_widget_preempt_allocated_size(

void gtk_custom_root_widget_set_resize_callback(
GtkCustomRootWidget *self,
void (*callback)(void*, Size),
void (*callback)(void*, CustomWidgetSize),
void *data
) {
self->resize_callback = callback;
Expand Down
6 changes: 3 additions & 3 deletions Sources/Gtk3CustomWidgets/include/gtk_custom_root_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extern "C" {
typedef struct {
gint width;
gint height;
} Size;
} CustomWidgetSize;

typedef struct _GtkCustomRootWidget {
GtkBin parent_instance;
Expand All @@ -26,7 +26,7 @@ typedef struct _GtkCustomRootWidget {
gboolean has_been_allocated;

void *resize_callback_data;
void (*resize_callback)(void*, Size);
void (*resize_callback)(void*, CustomWidgetSize);

GtkWidget *child;
} GtkCustomRootWidget;
Expand Down Expand Up @@ -82,7 +82,7 @@ void gtk_custom_root_widget_preempt_allocated_size(

void gtk_custom_root_widget_set_resize_callback(
GtkCustomRootWidget *self,
void (*callback)(void*, Size),
void (*callback)(void*, CustomWidgetSize),
void *data
);

Expand Down
4 changes: 2 additions & 2 deletions Sources/GtkCustomWidgets/gtk_custom_root_widget.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void gtk_custom_root_widget_allocate(
root_widget->allocated_height = height;

if (root_widget->resize_callback != NULL) {
Size size = { .width = width, .height = height };
CustomWidgetSize size = { .width = width, .height = height };
root_widget->resize_callback(root_widget->resize_callback_data, size);
}
}
Expand Down Expand Up @@ -111,7 +111,7 @@ void gtk_custom_root_widget_preempt_allocated_size(

void gtk_custom_root_widget_set_resize_callback(
GtkCustomRootWidget *self,
void (*callback)(void*, Size),
void (*callback)(void*, CustomWidgetSize),
void *data
) {
self->resize_callback = callback;
Expand Down
6 changes: 3 additions & 3 deletions Sources/GtkCustomWidgets/include/gtk_custom_root_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extern "C" {
typedef struct {
gint width;
gint height;
} Size;
} CustomWidgetSize;

typedef struct _GtkCustomRootWidget {
GtkWidget parent_instance;
Expand All @@ -24,7 +24,7 @@ typedef struct _GtkCustomRootWidget {
gboolean has_been_allocated;

void *resize_callback_data;
void (*resize_callback)(void*, Size);
void (*resize_callback)(void*, CustomWidgetSize);

GtkWidget *child;
} GtkCustomRootWidget;
Expand Down Expand Up @@ -72,7 +72,7 @@ void gtk_custom_root_widget_preempt_allocated_size(

void gtk_custom_root_widget_set_resize_callback(
GtkCustomRootWidget *self,
void (*callback)(void*, Size),
void (*callback)(void*, CustomWidgetSize),
void *data
);

Expand Down
Loading