Make ForEach Identifiable (extension of #245) #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess (#245) * Fixed reordering, insertion and removal in ForEach where Element: Identifiable No non-identifiable support in this commit * Made it work for non identifiables StressTestExample is broken * added fallback to old code where no keypath is specified * added node reusing bypass after discovering first duplicate * Fixed ForEach [MenuItem] compatibility, documentation improvement & cleanup sadly an argument name seems to be required on menuitem forEach initializer, the compiler is apparently unable to infer the right child from the context. * added tvOS excluding compiler flag for Slider Component in ForEachExample * Fixed reordering, insertion and removal in ForEach where Element: Identifiable No non-identifiable support in this commit # Conflicts: # Examples/Bundler.toml # Examples/Package.swift # Examples/Sources/ForEachExample/ForEachApp.swift # Sources/SwiftCrossUI/Views/ForEach.swift * Made it work for non identifiables StressTestExample is broken * should fix remaining rebase problems * Changed version of swift-collections to 1.2.1 to match swift 5.10 * Implemented requested changes, potentially additional ForEach initializer pending * fixed my merge messup * replaced upToNextMajor with upToNextMinor because major would lead to pulling packages unsupported on swift 5.10 tooling * requested changes: ignored notes.json, directly passed &children.stackLayoutCache, moved inserted inside the for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple extension of #245. Mia did all the work in that PR and I've just applied a few small changes that I wanted to add before merging into main to minimise breaking changes.