Skip to content

Fix UIKitBackend alert handlers never getting called #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackotter merged 1 commit into from
Jan 11, 2026
Merged

Fix UIKitBackend alert handlers never getting called #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Sources/SwiftCrossUI/Environment/Actions/PresentAlertAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ public struct PresentAlertAction {
} else {
nil
}
backend.showAlert(
alert,
window: window
) { actionIndex in
backend.showAlert(alert, window: window) { actionIndex in
actions[actionIndex].action()
continuation.resume(returning: actionIndex)
}
Expand Down
31 changes: 14 additions & 17 deletions Sources/UIKitBackend/UIKitBackend+Alert.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,14 @@ import SwiftCrossUI
import UIKit

extension UIKitBackend {
public final class Alert {
let controller: UIAlertController
var handler: ((Int) -> Void)?
public typealias Alert = UIAlertController

init() {
self.controller = UIAlertController(title: nil, message: nil, preferredStyle: .alert)
}
final class CustomAlertAction: UIAlertAction {
var handler: (() -> Void)?
}

public func createAlert() -> Alert {
Alert()
Alert(title: nil, message: nil, preferredStyle: .alert)
}

public func updateAlert(
Expand All @@ -21,15 +18,13 @@ extension UIKitBackend {
actionLabels: [String],
environment _: EnvironmentValues
) {
alert.controller.title = title
alert.title = title

for (i, actionLabel) in actionLabels.enumerated() {
let action = UIAlertAction(title: actionLabel, style: .default) {
[weak alert] _ in
guard let alert else { return }
alert.handler?(i)
for actionLabel in actionLabels {
let action = CustomAlertAction(title: actionLabel, style: .default) { action in
(action as! CustomAlertAction).handler?()
}
alert.controller.addAction(action)
alert.addAction(action)
}
}

Expand All @@ -43,11 +38,13 @@ extension UIKitBackend {
return
}

alert.handler = handleResponse
window.rootViewController!.present(alert.controller, animated: false)
for (index, action) in alert.actions.enumerated() {
(action as! CustomAlertAction).handler = { handleResponse(index) }
}
window.rootViewController!.present(alert, animated: true)
}

public func dismissAlert(_ alert: Alert, window: Window?) {
alert.controller.dismiss(animated: false)
alert.dismiss(animated: true)
}
}
Loading