Switching version option type

BREAKING CHANGE: Switch the version option to be a number and not a string. For example 4 instead of 'v4'.

Author: jdalrymple

Diff for: src/core/infrastructure/BaseService.ts

@@ -14,7 +14,7 @@ export interface BaseServiceOptions {
   jobToken?: string;
   host?: string;
   url?: string;
-  version?: 'v3' | 'v4';
+  version?: 3 | 4;
   rejectUnauthorized?: boolean;
   camelize?: boolean;
   requester?: Requester;
@@ -46,13 +46,13 @@ export class BaseService {
     profileMode = 'execution',
     host = 'https://gitlab.com',
     url = '',
-    version = 'v4',
+    version = 4,
     camelize = false,
     rejectUnauthorized = true,
     requester = KyRequester as Requester,
     requestTimeout = 300000,
   }: BaseServiceOptions = {}) {
-    this.url = [host, 'api', version, url].join('/');
+    this.url = [host, 'api', `v${version}`, url].join('/');
     this.headers = {};
     this.rejectUnauthorized = rejectUnauthorized;
     this.camelize = camelize;

Diff for: test/unit/infrastructure/BaseService.ts

@@ -33,7 +33,7 @@ describe('Creation of BaseService instance', () => {
   });
 
   test('API version should be modified', async () => {
-    const service = new BaseService({ host: 'https://testing.com', token: '1234', version: 'v3' });
+    const service = new BaseService({ host: 'https://testing.com', token: '1234', version: 3 });
 
     expect(service.url).toBe('https://testing.com/api/v3/');
   });
@@ -44,7 +44,10 @@ describe('Creation of BaseService instance', () => {
 
     service.show = jest.fn(() => RequestHelper.get(service, 'test'));
     KyRequester.get = jest.fn(() => ({
-      body: [{ id: 3, gravatar_enable: true }, { id: 4, gravatar_enable: false }],
+      body: [
+        { id: 3, gravatar_enable: true },
+        { id: 4, gravatar_enable: false },
+      ],
       headers: {},
     }));