Skip to content

feat: Add attestation entry point to Docker Images#1476

Merged
fabergat merged 29 commits intomainfrom
feat/add_attestation_validation_script
Mar 27, 2025
Merged

feat: Add attestation entry point to Docker Images#1476
fabergat merged 29 commits intomainfrom
feat/add_attestation_validation_script

Conversation

@fabergat
Copy link
Copy Markdown
Contributor

@fabergat fabergat commented Mar 5, 2025

Description

This PR adds the support to the attestation verification in offline mode and give a suggestion on how to override the Docker entry point for Docker and Docker Compose.

Closes: #1310

Note:

The key material in trusted_root.jsonl does not have a built-in expiration date, so anything signed before you generate the trusted root file will continue to successfully verify. Anything signed after the file is generated will verify until that Sigstore instance rotates its key material, which typically happens a few times per year. You will not know if key material has been revoked since you last generated the trusted root file.

Open questions:

  • Is this thing adding a lot more security?
  • Is it worth it complicate the config?

Changes

Testing Information

This is a build workflow that generates the attestation files: https://github.com/stacks-network/sbtc/actions/runs/13830677511/job/38694062940

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabergat fabergat marked this pull request as ready for review March 5, 2025 15:14
@fabergat fabergat requested review from aldur and djordon March 10, 2025 14:34
@djordon djordon added this to the sBTC: Withdrawal fine tuning milestone Mar 10, 2025
@djordon djordon added this to sBTC Mar 10, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in sBTC Mar 10, 2025
@djordon djordon added the chore label Mar 10, 2025
@djordon djordon moved this from Needs Triage to In Review in sBTC Mar 10, 2025
@aldur aldur requested a review from fdefelici March 10, 2025 14:45
Copy link
Copy Markdown
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few remarks.

I need also a clarification, to check if my undestanding is right about this need.
We are offering this attestation verification and related samples, to allow a user to create its own docker image with blockstack-cli and signer binary?

Comment thread docker/mainnet/gh-attestation/entry_point.sh
Comment thread docker/mainnet/gh-attestation/README.md Outdated
Comment thread docker/mainnet/gh-attestation/README.md Outdated
Comment thread docker/mainnet/gh-attestation/README.md
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in sBTC Mar 10, 2025
@fabergat
Copy link
Copy Markdown
Contributor Author

Added few remarks.

I need also a clarification, to check if my undestanding is right about this need. We are offering this attestation verification and related samples, to allow a user to create its own docker image with blockstack-cli and signer binary?

We would like to enforce another small step that automate the process to verify the images source, the idea is to limit the the possibility to run unsigned software. To add to our signer plus the partners

Copy link
Copy Markdown
Contributor

@aldur aldur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also modify the files under https://github.com/stacks-network/sbtc/blob/main/docker/mainnet/docker-compose.yml and the testnet corresponding version?

@djordon djordon moved this from In Progress to In Review in sBTC Mar 11, 2025
@aldur aldur temporarily deployed to Push to Docker March 12, 2025 12:57 — with GitHub Actions Inactive
@aldur aldur temporarily deployed to Push to Docker March 12, 2025 12:57 — with GitHub Actions Inactive
@aldur aldur requested a review from matteojug March 14, 2025 14:16
Comment thread .github/workflows/image-build-and-draft-release.yaml Outdated
Comment thread docker/mainnet/docker-compose.yml Outdated
Comment thread docker/mainnet/gh-attestation/README.md Outdated
Comment thread docker/mainnet/gh-attestation/README.md Outdated
Comment thread docker/mainnet/gh-attestation/entrypoint.sh Outdated
Comment thread docker/mainnet/gh-attestation/entrypoint.sh Outdated
Comment thread docker/mainnet/gh-attestation/entrypoint.sh Outdated
Comment thread docker/mainnet/gh-attestation/entrypoint.sh Outdated
@djordon djordon moved this from In Progress to In Review in sBTC Mar 25, 2025
Comment thread .github/actions/dockerfiles/Dockerfile.blocklist-client.debian Outdated
Comment thread .github/workflows/image-build-and-draft-release.yaml
Comment thread docker/mainnet/gh-attestation/README.md Outdated
Comment thread docker/mainnet/gh-attestation/entrypoint.sh
Comment thread .github/actions/dockerfiles/Dockerfile.blocklist-client.debian Outdated
Comment thread .github/actions/dockerfiles/Dockerfile.blocklist-client.debian Outdated
Comment thread .github/actions/dockerfiles/Dockerfile.blocklist-client.debian Outdated
@fabergat fabergat added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 5f0af83 Mar 27, 2025
8 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in sBTC Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Have our production Docker builds verify their attestation at runtime, before running

5 participants