Skip to content

[chore]: info about tests to readme#1497

Closed
MCJOHN974 wants to merge 1 commit intomainfrom
viktar/readme
Closed

[chore]: info about tests to readme#1497
MCJOHN974 wants to merge 1 commit intomainfrom
viktar/readme

Conversation

@MCJOHN974
Copy link
Copy Markdown
Contributor

@MCJOHN974 MCJOHN974 commented Mar 11, 2025

Description

Closes: no issue

I often use this command and sometimes loose it. Extract it from readme will be easier then extracting from my shell history. Is this readme okish place for this command or maybe signer/README.md will fit better?

Changes

Added few lines to readme

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MCJOHN974 MCJOHN974 requested a review from cylewitruk March 11, 2025 11:42
@MCJOHN974 MCJOHN974 marked this pull request as ready for review March 11, 2025 11:42
@MCJOHN974 MCJOHN974 enabled auto-merge March 11, 2025 11:42
@MCJOHN974 MCJOHN974 requested a review from djordon March 11, 2025 11:48
@matteojug
Copy link
Copy Markdown
Contributor

@MCJOHN974
Copy link
Copy Markdown
Contributor Author

MCJOHN974 commented Mar 11, 2025

Isn't this already covered by:

https://github.com/stacks-network/sbtc/blob/394dc72e5bc31db2e51d88f3f7445a724072fa56/README.md?plain=1#L82-L84

?

@matteojug I trying to use our make commands and they sometimes do not work well. This manual docker compose works fine every time I use it

Maybe it is a call to add some changes to Makefile, but I personally ok to just call this docker compose manually =)

@djordon
Copy link
Copy Markdown
Contributor

djordon commented Mar 12, 2025

@matteojug I trying to use our make commands and they sometimes do not work well. This manual docker compose works fine every time I use it

Maybe it is a call to add some changes to Makefile, but I personally ok to just call this docker compose manually =)

@MCJOHN974 what specific issues have you run into and how often are you running into them? What you added to the README is the make integration-env-up command but without basically running pnpm --filter run synth.

@github-project-automation github-project-automation Bot moved this to Needs Triage in sBTC Apr 2, 2025
@MCJOHN974
Copy link
Copy Markdown
Contributor Author

I can't reproduce any particular issue, however it still can be useful for running integration tests and look at emily logs

@MCJOHN974
Copy link
Copy Markdown
Contributor Author

I don't mind to close it though

@djordon
Copy link
Copy Markdown
Contributor

djordon commented Apr 10, 2025

Closing, since we cannot reproduce the underlying issue. And if we could, we should probably address that directly by updating the make command or solving the underlying problem.

@djordon djordon closed this Apr 10, 2025
auto-merge was automatically disabled April 10, 2025 15:10

Pull request was closed

@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in sBTC Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants