refactor: move testing utilities to a common location

This allows them to be used in tests in stackslib/ or testnet/.

Author: obycode

stackslib/src/chainstate/stacks/tests/block_construction.rs

@@ -5034,7 +5034,7 @@ fn paramaterized_mempool_walk_test(
 fn mempool_walk_test_next_nonce_with_highest_fee_rate_strategy() {
     let key_address_pairs: Vec<(Secp256k1PrivateKey, StacksAddress)> = (0..7)
         .map(|_user_index| {
-            let privk = StacksPrivateKey::new();
+            let privk = StacksPrivateKey::random();
             let addr = StacksAddress::from_public_keys(
                 C32_ADDRESS_VERSION_TESTNET_SINGLESIG,
                 &AddressHashMode::SerializeP2PKH,

stackslib/src/core/mod.rs

@@ -34,6 +34,8 @@ pub mod nonce_cache;
 
 #[cfg(test)]
 pub mod tests;
+#[cfg(any(test, feature = "testing"))]
+pub mod util;
 
 use std::cmp::Ordering;
 pub type StacksEpoch = GenericStacksEpoch<ExecutionCost>;

stackslib/src/core/tests/mod.rs

@@ -64,6 +64,7 @@ use crate::core::mempool::{
     db_get_all_nonces, MemPoolSyncData, MemPoolWalkSettings, MemPoolWalkTxTypes, TxTag,
     BLOOM_COUNTER_DEPTH, BLOOM_COUNTER_ERROR_RATE, MAX_BLOOM_COUNTER_TXS,
 };
+use crate::core::util::{insert_tx_in_mempool, make_stacks_transfer, to_addr};
 use crate::core::{FIRST_BURNCHAIN_CONSENSUS_HASH, FIRST_STACKS_BLOCK_HASH};
 use crate::net::Error as NetError;
 use crate::util_lib::bloom::test::setup_bloom_counter;