[bug]: Relay via multiple rcpt_domain using OR (||) operator doesn't work

[dpurnam]

What happened?

Email not sent via relay to rcpt_domain which uses wild card declaration or anything but the first declared domain

How can we reproduce the problem?

I can reproduce the problem by doing the following steps:

1. Setup routing rules (in webadmin > Settings > SMTP > Outbound > Routing page) as below

(if) is_local_domain('*', rcpt_domain) ==> 'local'
(if) rcpt_domain = ('gmail.com' || 'hotmail.com' || 'outlook.*' || 'microsoft.*' || 'live.*' || 'google.*') ==> 'brevo'
(else) 'false'

2. Setup Relay Host properly (in Webadmin > Settings > SMTP > Outbound > Remote Hosts page)
3. Test outbound email to multiple recepients including emails domains such as gmail.com, outlook.com and hotmail.com
4. Only the gmail.com recepient (first in the rcpt_domain list) receives the email via brevo. The outlook.com and hotmail.com recepients get the email but not via brevo but via localhost.

Version

v0.9.x

What database are you using?

RocksDB

What blob storage are you using?

RocksDB

Where is your directory located?

Internal

What operating system are you using?

Docker

Relevant log output

No logs are generated even after switching existing tracer to Trace Level.

Code of Conduct

• I agree to follow this project's Code of Conduct

[mdecimus]

The problem is that rcpt_domain = ('gmail.com' || 'hotmail.com' || 'outlook.*' || 'microsoft.*' || 'live.*' || 'google.*') is not a valid expression. It should be ['gmail.com', 'hotmail.com].contains(rcpt_domain). Then for the wildcards you need to either define a lookup list (cleaner approach) or manually split rcpt_domainby.` and then check the first token.