Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions without coreference should not carry over slots #496

Open
gcampax opened this issue Feb 24, 2021 · 0 comments
Open

Questions without coreference should not carry over slots #496

gcampax opened this issue Feb 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working P2 We need to fix it (backlog) templates Issues with templates and the state machine

Comments

@gcampax
Copy link
Contributor

gcampax commented Feb 24, 2021

From a tester's log:

U: what is the biggest hit by Taylor swift
UT: $dialogue @org.thingpedia.dialogue.transaction.execute;
UT: sort(popularity desc of @com.spotify.song() filter contains(artists, null^^com.spotify:artist("taylor swift")))[1];
A: The most popular track is willow. It is a track in the album evermore by Taylor Swift.
AT: $dialogue @org.thingpedia.dialogue.transaction.sys_recommend_one;
U: who sings shake it off
UT: $dialogue @org.thingpedia.dialogue.transaction.execute;
UT: [artists] of sort(popularity desc of @com.spotify.song() filter contains(artists, "spotify:artist:06HL4z0CvFAxyc27GXpf02"^^com.spotify:artist("Taylor Swift")) && id == "spotify:track:0lx2cLdOt3piJbcaXIV74f"^^com.spotify:song("willow"))[1];

The second parse is incorrect, it should be:

[artists] of @com.spotify.song() filter id =~ "shake it off";

The second parse arises because we carry over the slots, due to bad training data.

@gcampax gcampax added bug Something isn't working templates Issues with templates and the state machine labels Feb 24, 2021
@gcampax gcampax added this to the Almond 2.0 Beta milestone Feb 24, 2021
@gcampax gcampax self-assigned this Apr 5, 2021
@gcampax gcampax removed this from the Almond 2.0 Beta milestone Apr 28, 2021
@nrser nrser added the P2 We need to fix it (backlog) label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 We need to fix it (backlog) templates Issues with templates and the state machine
Projects
None yet
Development

No branches or pull requests

2 participants