Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile with npm 7 #590

Open
gcampax opened this issue Apr 28, 2021 · 2 comments
Open

Does not compile with npm 7 #590

gcampax opened this issue Apr 28, 2021 · 2 comments
Labels
bug Something isn't working P2 We need to fix it (backlog)

Comments

@gcampax
Copy link
Contributor

gcampax commented Apr 28, 2021

For some unscrutable reason, npm 7 changed how git deps are prepared, and now repos that use genie-toolkit (like almond-server or thingpedia-common-devices) no longer build genie-toolkit correctly: the templates fail to build because they fail to locate the genie-toolkit.d.ts file

I think the solution here will be to remove entirely the ability to specify templates outside of Genie. Templates will be shipped with Genie and there will only ever be one template pack (+ flags). Programmability of dialogues will come in a different way, by configuring the transaction/slot filling templates with custom ThingTalk logic (see https://wiki.almond.stanford.edu/en/genie/design-notes/unified-control-language for a summary of current designs).
@rayslxu opinions? We'll drop sempre templates when we do that.

(originally reported independently by @AydanPirani and @james-zhuang)

@gcampax gcampax added the bug Something isn't working label Apr 29, 2021
@nrser nrser added the P2 We need to fix it (backlog) label Aug 3, 2021
@sileix
Copy link
Member

sileix commented Nov 29, 2021

Agree with shipping pre-compiled templates.

@gcampax
Copy link
Contributor Author

gcampax commented Nov 29, 2021

FWIW that issue should be long solved, but we have other issues with node 16 and npm 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

3 participants