From 8dd649453439c5e95ef01684edeee1b1db7a3c6d Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 10 Oct 2023 17:41:21 -0400 Subject: [PATCH 1/3] Build and publish the 'unstable' tag correctly --- .github/workflows/publish-unstable.yml | 3 +++ packages/preact/preact-utils/package.json | 8 +++++++- packages/preact/preact/package.json | 8 +++++++- packages/react/react/package.json | 8 +++++++- packages/react/use-strict-lifecycle/package.json | 8 +++++++- packages/universal/collections/package.json | 8 +++++++- packages/universal/core-utils/package.json | 8 +++++++- packages/universal/core/package.json | 8 +++++++- packages/universal/debug/package.json | 8 +++++++- packages/universal/modifier/package.json | 8 +++++++- packages/universal/reactive/package.json | 8 +++++++- packages/universal/renderer/package.json | 8 +++++++- packages/universal/resource/package.json | 8 +++++++- packages/universal/runtime/package.json | 8 +++++++- packages/universal/service/package.json | 8 +++++++- packages/universal/shared/package.json | 8 +++++++- packages/universal/tags/package.json | 8 +++++++- packages/universal/universal/package.json | 6 ++++++ packages/universal/verify/package.json | 8 +++++++- packages/vue/vue/package.json | 8 +++++++- workspace/unstable-release/src/publish.js | 2 +- 21 files changed, 136 insertions(+), 19 deletions(-) diff --git a/.github/workflows/publish-unstable.yml b/.github/workflows/publish-unstable.yml index cad8403b..27e11251 100644 --- a/.github/workflows/publish-unstable.yml +++ b/.github/workflows/publish-unstable.yml @@ -28,6 +28,9 @@ jobs: - name: set versions run: node ./workspace/unstable-release/src/version.js + - name: build + run: pnpm build + - name: npm publish run: node ./workspace/unstable-release/src/publish.js env: diff --git a/packages/preact/preact-utils/package.json b/packages/preact/preact-utils/package.json index fcc3c8f6..84a62100 100644 --- a/packages/preact/preact-utils/package.json +++ b/packages/preact/preact-utils/package.json @@ -36,5 +36,11 @@ }, "peerDependencies": { "preact": ">=10" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/preact/preact/package.json b/packages/preact/preact/package.json index e6a70f09..3d583f39 100644 --- a/packages/preact/preact/package.json +++ b/packages/preact/preact/package.json @@ -53,5 +53,11 @@ }, "peerDependencies": { "preact": "^10.11.0" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/react/react/package.json b/packages/react/react/package.json index ddfb0cdc..7aa0e1ca 100644 --- a/packages/react/react/package.json +++ b/packages/react/react/package.json @@ -56,5 +56,11 @@ "peerDependencies": { "react": "^18.2.0", "react-dom": "^18.2.0" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/react/use-strict-lifecycle/package.json b/packages/react/use-strict-lifecycle/package.json index 50c14a09..42d02fe1 100644 --- a/packages/react/use-strict-lifecycle/package.json +++ b/packages/react/use-strict-lifecycle/package.json @@ -42,5 +42,11 @@ "react": "^18.2.0", "react-dom": "^18.2.0", "scheduler": "^0.23.0" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/collections/package.json b/packages/universal/collections/package.json index 18abe0fb..9940fcc3 100644 --- a/packages/universal/collections/package.json +++ b/packages/universal/collections/package.json @@ -41,5 +41,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/core-utils/package.json b/packages/universal/core-utils/package.json index 2b902e84..cf9f5981 100644 --- a/packages/universal/core-utils/package.json +++ b/packages/universal/core-utils/package.json @@ -31,5 +31,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/core/package.json b/packages/universal/core/package.json index 321a09a0..07ce2c61 100644 --- a/packages/universal/core/package.json +++ b/packages/universal/core/package.json @@ -32,5 +32,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/debug/package.json b/packages/universal/debug/package.json index 8c64b9f6..aaeed975 100644 --- a/packages/universal/debug/package.json +++ b/packages/universal/debug/package.json @@ -51,5 +51,11 @@ "@starbeam-dev/build-support": "workspace:^", "@types/node": "18.16.1", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/modifier/package.json b/packages/universal/modifier/package.json index 9df0f51f..c61486f4 100644 --- a/packages/universal/modifier/package.json +++ b/packages/universal/modifier/package.json @@ -39,5 +39,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/reactive/package.json b/packages/universal/reactive/package.json index 608b53ec..3bcb489d 100644 --- a/packages/universal/reactive/package.json +++ b/packages/universal/reactive/package.json @@ -37,5 +37,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/renderer/package.json b/packages/universal/renderer/package.json index 729927d1..7425ec60 100644 --- a/packages/universal/renderer/package.json +++ b/packages/universal/renderer/package.json @@ -38,5 +38,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/resource/package.json b/packages/universal/resource/package.json index 71272d71..f47023bd 100644 --- a/packages/universal/resource/package.json +++ b/packages/universal/resource/package.json @@ -38,5 +38,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/runtime/package.json b/packages/universal/runtime/package.json index 3ba02863..035ad9e5 100644 --- a/packages/universal/runtime/package.json +++ b/packages/universal/runtime/package.json @@ -38,5 +38,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/service/package.json b/packages/universal/service/package.json index a6536932..53993640 100644 --- a/packages/universal/service/package.json +++ b/packages/universal/service/package.json @@ -38,5 +38,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/shared/package.json b/packages/universal/shared/package.json index b1cd081b..95f50c78 100644 --- a/packages/universal/shared/package.json +++ b/packages/universal/shared/package.json @@ -31,5 +31,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/tags/package.json b/packages/universal/tags/package.json index 182e9ed7..ab82a90e 100644 --- a/packages/universal/tags/package.json +++ b/packages/universal/tags/package.json @@ -34,5 +34,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/universal/universal/package.json b/packages/universal/universal/package.json index 44ba35ec..bbb9df60 100644 --- a/packages/universal/universal/package.json +++ b/packages/universal/universal/package.json @@ -18,6 +18,12 @@ "main": "dist/index.cjs", "types": "dist/index.d.ts" }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ], "starbeam": { "type": "library:public" }, diff --git a/packages/universal/verify/package.json b/packages/universal/verify/package.json index 1429fcd0..6fc5f950 100644 --- a/packages/universal/verify/package.json +++ b/packages/universal/verify/package.json @@ -33,5 +33,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/packages/vue/vue/package.json b/packages/vue/vue/package.json index 8145b535..7e7d194e 100644 --- a/packages/vue/vue/package.json +++ b/packages/vue/vue/package.json @@ -51,5 +51,11 @@ }, "peerDependencies": { "vue": "^3.3.4" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] } diff --git a/workspace/unstable-release/src/publish.js b/workspace/unstable-release/src/publish.js index bce68f53..31ddec19 100644 --- a/workspace/unstable-release/src/publish.js +++ b/workspace/unstable-release/src/publish.js @@ -53,7 +53,7 @@ async function publish() { console.info(`Publishing ${workspace}`); try { await execaCommand( - "npm publish --tag=unstable --verbose --access=public", + "pnpm publish --tag=unstable --verbose --access=public", { cwd: dirname(workspace), }, From 037a7469b8648327630f275edf7df76c2dad89b2 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 10 Oct 2023 17:45:54 -0400 Subject: [PATCH 2/3] build needs to happen first --- .github/workflows/publish-unstable.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-unstable.yml b/.github/workflows/publish-unstable.yml index 27e11251..c1506e72 100644 --- a/.github/workflows/publish-unstable.yml +++ b/.github/workflows/publish-unstable.yml @@ -25,12 +25,12 @@ jobs: # This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable node-registry-url: 'https://registry.npmjs.org' - - name: set versions - run: node ./workspace/unstable-release/src/version.js - - name: build run: pnpm build + - name: set versions + run: node ./workspace/unstable-release/src/version.js + - name: npm publish run: node ./workspace/unstable-release/src/publish.js env: From 1dcaf37ea6a980a6822b2427a8d912fad22cb159 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 10 Oct 2023 20:05:53 -0400 Subject: [PATCH 3/3] fix lint --- packages/universal/universal/package.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/universal/universal/package.json b/packages/universal/universal/package.json index bbb9df60..ebb96893 100644 --- a/packages/universal/universal/package.json +++ b/packages/universal/universal/package.json @@ -18,12 +18,6 @@ "main": "dist/index.cjs", "types": "dist/index.d.ts" }, - "files": [ - "dist", - "README.md", - "CHANGELOG.md", - "LICENSE.md" - ], "starbeam": { "type": "library:public" }, @@ -47,5 +41,11 @@ "@starbeam/eslint-plugin": "workspace:^", "@starbeam-dev/build-support": "workspace:^", "rollup": "^3.29.2" - } + }, + "files": [ + "dist", + "README.md", + "CHANGELOG.md", + "LICENSE.md" + ] }