Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On possibility of updating to RDF4J #20

Open
schivmeister opened this issue May 5, 2017 · 6 comments
Open

On possibility of updating to RDF4J #20

schivmeister opened this issue May 5, 2017 · 6 comments

Comments

@schivmeister
Copy link

schivmeister commented May 5, 2017

I was wondering why, instead of updating to RDF4J, Pinto was only updated to Sesame 4.x? Was this a conscious decision based on certain things or just a preference?

http://docs.rdf4j.org/migration/

@mhgrove
Copy link
Member

mhgrove commented May 5, 2017

just a preference, mostly because that's the version we've standardized on

@schivmeister
Copy link
Author

schivmeister commented May 5, 2017

I don't think it's that much work from 4.x, but I won't know until I dig. It looks like namespace changes mostly, but there could be other regressions waiting. But you have a nice test suite already that should cover that.

By any chance, if I chose to pursue an update myself, I won't be able to do it since your Sesame dependencies are coming from Stardog repositories, correct?

@mhgrove
Copy link
Member

mhgrove commented May 15, 2017

no, this is not used in stardog, so it could be upgraded without affecting anything else

@schivmeister
Copy link
Author

schivmeister commented Mar 14, 2018

@mhgrove So, I finally got to this, but I am not sure if https://github.com/mhgrove/cp-openrdf-utils is up-to-date or there are some internal changes that you didn't make public. The latest version there is 4.0.1 but here it's 4.0.2.

After updating the namespaces to RDF4J, the build and all but two tests pass in there. And here, build fails because Models2.toList() is having an incompatible signature (List<Value>, Model) vs. (List<Resource>). UUIDCodec.writeValue() also has an incompatible return type ResourceBuilder vs. Value.

There appear to be no other errors (there was one wrt URI, but I changed that to IRI and it became happy). So I think it's not too much work to update to RDF4J as this looks close. I can send a pull request for both projects if you can help clarify those remaining issues.

@mhgrove
Copy link
Member

mhgrove commented Mar 14, 2018

not sure what the version mismatch is for the openrdf utils, but probably not a big deal. the migration sounds good otherwise

@schivmeister
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants