Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V6] Lower timer - speed up #827

Open
tabaktoni opened this issue Nov 13, 2023 · 1 comment
Open

[V6] Lower timer - speed up #827

tabaktoni opened this issue Nov 13, 2023 · 1 comment
Assignees
Labels
Type: feature New feature or request

Comments

@tabaktoni
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
After refactoring waitForTransaction on v5.23.0, it is possible now to lower timeout to 1s and gain ~x2.5 performance.
However, some contract tests still failed at this speed.
This feature needs more testing / communicating with nodes regarding the "Readiness" status for TX.
At the moment even though the transaction status is SUCCEEDED and ACCEPTED_ON_L2 pending block nodes are not ready to work with the contract/transaction.
Investigate for contract do we need to check that the latest block, instead of pending?
For transactions why txHash is unknown if the status is SUCCEEDED and ACCEPTED_ON_L2 on pending Block

Describe the solution you'd like
Lower RPC retryInterval to 1000 ms.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@tabaktoni tabaktoni added the Type: feature New feature or request label Nov 13, 2023
@tabaktoni tabaktoni self-assigned this Nov 13, 2023
@vibenedict
Copy link

Hi, i will like to take up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants