Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starknet-js compatibility test suite for sequenceers #996

Open
tdelabro opened this issue Mar 5, 2024 · 3 comments
Open

starknet-js compatibility test suite for sequenceers #996

tdelabro opened this issue Mar 5, 2024 · 3 comments
Labels
Type: feature New feature or request

Comments

@tdelabro
Copy link

tdelabro commented Mar 5, 2024

Is your feature request related to a problem? Please describe.
At https://github.com/keep-starknet-strange/madara we are building starknet sequencers.
Other projects are doing so and others are building full nodes.
All are expected to integrate with starknet.js seamlessly.

Right now we are trying to maintain this compatibility in our CI with a custom suite of tests we wrote that cover most of the lib features. You can find this repo here: https://github.com/keep-starknet-strange/sequencer-js-compatibility-tests. It is used as a gh action in madara.

The issue is that we don't have the expertise to keep this suite of tests up to date with your lib upgrade, so it ends up breaking for bad reasons.

Describe the solution you'd like
We would like you, to write and maintain such a test suite, keep it always up to date with your every release, and expose it as a simple and efficient gh action.

@tdelabro tdelabro added the Type: feature New feature or request label Mar 5, 2024
@ivpavici
Copy link
Collaborator

ivpavici commented Mar 6, 2024

Hello!
Thanks for pointing this out! Unfortunately we don't have capacity for this currently, but maybe it could be done via a OnlyDust bounty!

@ivpavici ivpavici added the OnlyDust Open for OnlyDust contributors label Mar 6, 2024
@PhilippeR26
Copy link
Collaborator

PhilippeR26 commented Mar 6, 2024

Hello,
For short term, you can do the same thing than Lava project : use manually the Starknet.js test suite, not to test Starknet.js, but to test their nodes.
For longer term, I will soon have a look at this subject.
To be able to contact you directly, what's your Discord Id (mine is @Phil26)?

@tdelabro
Copy link
Author

tdelabro commented Mar 6, 2024

@PhilippeR26 I don't use discord, you can join me on telegram @timothee_delabrouille

@ivpavici ivpavici added the ODHack Issue to assign for the ODHack event label Apr 19, 2024
@ivpavici ivpavici removed OnlyDust Open for OnlyDust contributors ODHack Issue to assign for the ODHack event labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants