-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test and support for negative Signed integers smaller than 252 bits #1177
base: develop
Are you sure you want to change the base?
Conversation
test: added new tests for data types
Hello @tabaktoni @ivpavici ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the linked issue isn't to just create the corresponding utility classes but to actually use them for request/response handling.
Also, CairoInt
looks like it should be an abstract class and the type implementation classes look like they could have improved code reuse.
Hello @penovicp, I have a doubt about where exactly I should use those classes for request/response handling. Could you provide some guidance? |
This comment describes what the required behaviour should be. The existing data type utility classes such as CairoUint256 and CairoUint512 can be checked to see how and where the signed integer classes should be used. |
@penovicp Already used the utility classes, please let me know if you see that I'm missing something |
feat: added new data types
test: added new tests for data types
#1014
Motivation and Resolution
Created new Cairo Data Types integer classes and their unit tests for every range of bits below 252, similar to the
uint256.ts
file.Development related changes
Checklist: