WebSockets #1251
Open
WebSockets #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Heads working fine
ivpavici
reviewed
Oct 30, 2024
__tests__/WebSocketChannel.test.ts
Outdated
|
|
||
| // websocket | ||
| const webSocketChannel = new WebSocketChannel({ | ||
| nodeUrl: 'wss://toni.spaceshard.io/rpc/v0_8', |
There was a problem hiding this comment.
flagging this to not forget to change later :D
__tests__/WebSocketChannel.test.ts
Outdated
|
|
||
| describe('websocket regular endpoints - pathfinder test', () => { | ||
| const webSocketChannel = new WebSocketChannel({ | ||
| nodeUrl: 'wss://toni.spaceshard.io/rpc/v0_8', |
There was a problem hiding this comment.
flagging here as well for later, also maybe to extract into constant
| reject(Error(`error on ${method}, ${message.error}`)); | ||
| } | ||
| } | ||
| // console.log(`data from ${method} response`, data); |
There was a problem hiding this comment.
Still need it for testing as this PR can't be 100% complete before RPC 0.8 final release, Pathfinder WS Release and Devnet WS Release.
This is more like PrePR all working and can be checked but will be updated later.
| * ``` | ||
| */ | ||
| public async waitForUnsubscription(forSubscriptionId?: number) { | ||
| // unsubscribe |
There was a problem hiding this comment.
can this comment be removed?
| } | ||
|
|
||
| /** | ||
| * subscribe to pending transactions (mempool) |
There was a problem hiding this comment.
todo add params on this and rest that are missing
There was a problem hiding this comment.
I think it is auto add on doccs ? @penovicp
src/channel/ws_0_8.ts
Outdated
|
|
||
| private onMessageProxy(event: MessageEvent<any>) { | ||
| const message: WebSocketEvent = JSON.parse(event.data); | ||
| // console.log('onMessage:', data); |
penovicp
reviewed
Oct 30, 2024
Co-authored-by: Ivan Pavičić <[email protected]>
Co-authored-by: Ivan Pavičić <[email protected]>
Co-authored-by: Ivan Pavičić <[email protected]>
isows use ws, at least it should use installed one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Blocked by:
TBD
RPC version (if applicable)
0.8
Usage related changes
Development related changes
Checklist: