Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional fallbackNodeUrls property to RpcProvider #905

Closed

Conversation

jereldlimjy
Copy link

Motivation and Resolution

Solve issue #872

Usage related changes

...

Development related changes

...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for starknetjs ready!

Name Link
🔨 Latest commit eae7f71
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/65825d2ced05a400082a5b23
😎 Deploy Preview https://deploy-preview-905--starknetjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a notable change with the channel/provider split in the upcoming v6 version that relates to how underlying requests are made, so adding this feature should be based on and the PR should target the beta branch.

@eliotstock
Copy link

@penovicp, we'd love to use this quite soon in some downstream dApps.

When do you see v6 being released?

Could we do a v5 version in parallel, do you think?

@ivpavici
Copy link
Collaborator

ivpavici commented Jan 9, 2024

hello!

I want to clarify the steps for this PR!
First, @eliotstock you would like this PR to be included into Starknet.js v5? If that is the case, it's possible!
Second, for Sn.js v6, @jereldlimjy should modify it a bit and target the beta branch, do you want to do it?

Also, adding a test would be awesome!

@penovicp
Copy link
Collaborator

penovicp commented Mar 4, 2024

Superseded by #980

@penovicp penovicp closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants