Skip to content
This repository has been archived by the owner on Aug 19, 2019. It is now read-only.

babel 7 errors #9

Open
laggingreflex opened this issue Mar 4, 2017 · 7 comments
Open

babel 7 errors #9

laggingreflex opened this issue Mar 4, 2017 · 7 comments

Comments

@laggingreflex
Copy link

I just updated my dependencies to babel 7 and it seems to have broken start-babel-cli. I think it's because it uses babel-register@6 and it seems to be incompatible with other plugins that I'm usng (stage-0) that I've also updated to v7. Particularly the spread operator. Here's a repro:

    "babel-cli": "^7.0.0-alpha.1",
    "babel-preset-es2015": "^7.0.0-alpha.1",
    "babel-preset-stage-0": "^7.0.0-alpha.1",
{
  "presets": [
    "es2015",
    "stage-0"
  ],
}

tasks file:

const a = {}

const b = {}

const c = {...a ,...b}

(doesn't need tasks, it'll break on just parsing)

I think it breaks specifically when babel-register@6 is used in conjunction with other babel-plugins/presets that are v7.

I'm not sure but it could be possible that other way around might break things too - i.e. if start-babel-cli upgrades to babel-register@7 and a project still uses babel plugins @v6.

@deepsweet
Copy link
Member

we should create [email protected] or just wait :) especially for this one.

@xtuc
Copy link

xtuc commented Aug 11, 2017

Yes, Babel 7 plugins are only guarantee to work with Babel 7.

@deepsweet
Copy link
Member

afaik v7.0.0-alpha.19 is the last alpha, so we can proceed pretty soon.

@fmal
Copy link

fmal commented Apr 18, 2018

@deepsweet any change that you could publish new version of this package that uses @babel/register ? I have updated my deps to babel 7 and run into this issue as well .

I considered sending PR but this package depends on babel-preset-start and start-runner/babel which would itself have to be updated.

Thanks!

@deepsweet
Copy link
Member

oh, a lot of things are happening right now :) check out the https://github.com/deepsweet/start – Babel 7 and even ESM. it's close to be announced and then I'm going to deprecate old start- stuff.

@fmal
Copy link

fmal commented Apr 18, 2018

I see, the upcoming version looks neat, looking forward to it. in the meantime i will use my own wrapper around https://github.com/start-runner/cli-core 😃

@deepsweet
Copy link
Member

That's the reason why I made CLI "core" lib in the first place :) I hope that new require option from the next Start will cover every possible scenario – https://github.com/deepsweet/start/tree/master/packages/cli#startcli

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants