Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the claim method to claim multiple guarantees #26

Open
geoknee opened this issue May 10, 2021 · 1 comment
Open

Allow the claim method to claim multiple guarantees #26

geoknee opened this issue May 10, 2021 · 1 comment

Comments

@geoknee
Copy link
Contributor

geoknee commented May 10, 2021

  • we already allow for the token type and the target channel outcome to be indexed in the transaction calldata, with an escape hatch, empty array [] implying "do them all".
  • if you have many channels virtually funded through the same hub, you will likely want to claim all of the guarantees. SO we should upgrade targetChannelIndex: number to targetChannelIndices: number[].

targetChannelIndex: number,

@geoknee
Copy link
Contributor Author

geoknee commented May 14, 2021

This presents a bit of a challenge, both:

  1. because we now to specify payout indices for each target, for each target index in some target indices for each asset in the outcome of the "origin" channel. Thus the exitRequest becomes quite complicated.
  2. I anticipate we will run into "stack too deep" difficulties with this large number of variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant