Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and warn when unsupported shells are being used (e.g. fish) #1393

Open
sourishkrout opened this issue May 30, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@sourishkrout
Copy link
Member

sourishkrout commented May 30, 2024

Runme should be able to detect when an unsupported shell is being used via $SHELL and $0 and could warn accordingly.

The current error message looks something like this which isn't particularly helpful.

error: Internal failure executing runner: open /var/folders/hn/3tbqz8pd49q9yl2ns43qx6fh0000gp/T/512117330/.env_start: no such file or directory

Let's detect unsupported shells (e.g., fish, PowerShell).

Plan to show warning message with link to documentation for unsupported shells.

Provide button to open Documentation URL to be configurable for potential Stateful-specific overrides.

@sourishkrout sourishkrout added the bug Something isn't working label May 30, 2024
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 16, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 20, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
pastuxso added a commit that referenced this issue Aug 28, 2024
This PR introduces changes to do a best effort to determine if the shell
is supported.

Closes: #1393
@sourishkrout
Copy link
Member Author

sourishkrout commented Sep 23, 2024

Let's add a "Don't ask again" option to the notification, similar to https://github.com/stateful/vscode-runme/blob/main/src/extension/messaging.ts#L100-L102, @pastuxso, please. I think we want that before we can turn on the warning by default.

We should probably say Don't warn again.

@sourishkrout
Copy link
Member Author

@pastuxso let's flip the experiment to be default true to expose it publicly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants