Merge pull request #27 from statelyai/revert-24-davidkpiano/better-serialization

Revert "Better serialization"

Author: davidkpiano

.changeset/sixty-candles-attack.md

@@ -0,0 +1,5 @@
+---
+"@statelyai/inspect": patch
+---
+
+Revert serialization changes

src/browser.ts

@@ -1,10 +1,6 @@
 import safeStringify from 'fast-safe-stringify';
 import { AnyEventObject, Observer, Subscribable, toObserver } from 'xstate';
-import {
-  InspectorOptions,
-  createInspector,
-  defaultInspectorOptions,
-} from './createInspector';
+import { InspectorOptions, createInspector } from './createInspector';
 import { Adapter, Inspector, StatelyInspectionEvent } from './types';
 import { UselessAdapter } from './useless';
 
@@ -169,14 +165,7 @@ export class BrowserAdapter implements Adapter {
       ) {
         this.status = 'connected';
         this.deferredEvents.forEach((event) => {
-          const preSerializedEvent = defaultInspectorOptions.serialize(
-            event,
-            event
-          );
-          const serializedEvent = this.options.serialize(
-            preSerializedEvent,
-            event
-          );
+          const serializedEvent = this.options.serialize(event);
           this.targetWindow?.postMessage(serializedEvent, '*');
         });
       }
@@ -195,11 +184,7 @@ export class BrowserAdapter implements Adapter {
     if (this.options.send) {
       this.options.send(event);
     } else if (this.status === 'connected') {
-      const preSerializedEvent = defaultInspectorOptions.serialize(
-        event,
-        event
-      );
-      const serializedEvent = this.options.serialize(preSerializedEvent, event);
+      const serializedEvent = this.options.serialize(event);
       this.targetWindow?.postMessage(serializedEvent, '*');
     }
 

src/createInspector.test.ts

@@ -61,7 +61,7 @@ test('Creates an inspector for a state machine', async () => {
           },
           {
             "event": {
-              "input": null,
+              "input": undefined,
               "type": "xstate.init",
             },
             "sessionId": "x:0",

src/createInspector.ts

@@ -11,7 +11,6 @@ import { AnyActorRef, InspectionEvent, Snapshot } from 'xstate';
 import pkg from '../package.json';
 import { idleCallback } from './idleCallback';
 import safeStringify from 'safe-stable-stringify';
-import { serialize } from 'superjson';
 
 function getRoot(actorRef: AnyActorRef) {
   let marker: AnyActorRef | undefined = actorRef;
@@ -34,10 +33,7 @@ function getRootId(actorRefOrId: AnyActorRef | string): string | undefined {
 
 export interface InspectorOptions {
   filter?: (event: StatelyInspectionEvent) => boolean;
-  serialize?: (
-    event: StatelyInspectionEvent,
-    originalEvent: StatelyInspectionEvent
-  ) => StatelyInspectionEvent;
+  serialize?: (event: StatelyInspectionEvent) => StatelyInspectionEvent;
   /**
    * Whether to automatically start the inspector.
    *
@@ -48,8 +44,7 @@ export interface InspectorOptions {
 
 export const defaultInspectorOptions: Required<InspectorOptions> = {
   filter: () => true,
-  serialize: (event) =>
-    serialize(event).json as unknown as StatelyInspectionEvent,
+  serialize: (event) => event,
   autoStart: true,
 };
 
@@ -62,11 +57,10 @@ export function createInspector<TAdapter extends Adapter>(
       // Event filtered out
       return;
     }
-    const preSerializedEvent = defaultInspectorOptions.serialize(event, event);
-    const serializedEvent =
-      options?.serialize?.(preSerializedEvent, event) ?? preSerializedEvent;
-
+    const serializedEvent = options?.serialize?.(event) ?? event;
+    // idleCallback(() => {
     adapter.send(serializedEvent);
+    // })
   }
   const inspector: Inspector<TAdapter> = {
     adapter,