Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `app.escape_html' #8

Open
kodekrash opened this issue Feb 6, 2016 · 8 comments
Open

undefined method `app.escape_html' #8

kodekrash opened this issue Feb 6, 2016 · 8 comments

Comments

@kodekrash
Copy link

Using middleman 4.1.1

When running bundle exec middleman build

middleman-sitemap-0.0.13/lib/middleman-sitemap/extension.rb:94:in block in encode: undefined method app.escape_html

Verified that escape_html is available to middleman with simple test template

<%= encode_html( '<p>Hello world!</p>' ) %>
@atipugin
Copy link

+1 Same here

@bithavoc
Copy link

bithavoc commented Jul 2, 2016

Looks like escape_html is gone in middleman 4.1

@GSI
Copy link

GSI commented Nov 15, 2016

Apparently escape_html is just as present in MM 4.1 (padrino-helpers 0.13) as it was in 3.3 (padrino-helpers-0.12).

@powelleric
Copy link

This issue was fixed by @matsu911 and is in a pull request.

@matsu911 also forked the repo and added this fix to the fork.

I was able to use the forked repo with Middleman v4 and everything is working great. This is what I added to my Gemfile:

gem "middleman-sitemap", :git => "https://github.com/matsu911/middleman-sitemap" 

@JarLowrey
Copy link

JarLowrey commented May 9, 2017

Using that repo gives the error /home/james/.rvm/rubies/ruby-2.3.1/lib/ruby/gems/2.3.0/bundler/gems/middleman-sitemap-b52c2256d418/templates/sitemap.xml.erb:4:in 'block (2 levels) in singleton class': undefined method '+' for nil:NilClass (NoMethodError)

@subelsky
Copy link

I was able to use the @matsu911 branch as suggested by @powelleric - thanks!

@chrishough
Copy link

gem 'middleman-sitemap', git: 'https://github.com/matsu911/middleman-sitemap' worked for me too @matsu911 @powelleric

@xymetry
Copy link

xymetry commented Aug 1, 2023

gem 'middleman-sitemap', git: 'https://github.com/matsu911/middleman-sitemap' worked for me, too. Thank you, @matsu911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants