Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace getCanonicalHead from core-db to ForkedChain #2887

Open
jangko opened this issue Nov 28, 2024 · 0 comments
Open

Replace getCanonicalHead from core-db to ForkedChain #2887

jangko opened this issue Nov 28, 2024 · 0 comments
Labels
EL

Comments

@jangko
Copy link
Contributor

jangko commented Nov 28, 2024 •
edited
Loading

The meaning of getCanonicalHead of core-db now has been shifted to getBaseHead. The one provide canonical head now is ForkedChain.
Change core-db getCanonicalHead into getBaseHead to avoid confusion. And add getCanonicalHead or getHead to ForkedChain.

BASE > FINALIZED HEAD > CANONICAL HEAD

see https://notes.status.im/nimbus-merge-first-el?both=#Glossary

we Might as well add getFinalizedHead to FC
@jangko jangko added the EL label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jangko