Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“Block user” remains in context menu after block #16948

Closed
glitchminer opened this issue Dec 12, 2024 · 2 comments · Fixed by #16978
Closed

“Block user” remains in context menu after block #16948

glitchminer opened this issue Dec 12, 2024 · 2 comments · Fixed by #16978
Assignees
@jrainville
Labels
bug Something isn't working core-team
Milestone
2.33.0 Beta

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

After blocking a user it's expected that the context menu for that use updates to remove that option.

Image
Image

Steps to reproduce

  • Block user
  • Check context menu for user in members list of community

Expected behavior

Block user option is removed

Actual behavior

Block user option is still available.

Additional Information

  • Status desktop version: 2.32 RC4
  • Operating System: Mac
@glitchminer glitchminer added bug Something isn't working core-team labels Dec 12, 2024
@glitchminer glitchminer added this to the 2.32.0 Beta milestone Dec 12, 2024
@caybro caybro self-assigned this Dec 12, 2024
@caybro caybro moved this from Backlog to Next in Status Desktop/Mobile Board Dec 12, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 12, 2024
@jrainville
Copy link
Member

Moved to 2.33 since it's not a high impact regression worth fixing in the RC

@caybro
Copy link
Member

caybro commented Dec 13, 2024 •
edited
Loading

@jrainville looks like a NIM problem; I verified we call the ContactStore's contactStore.blockContact(publicKey) (which in turn calls profileSectionModule.contactsModule.blockContact(pubKey)) method just fine; yet the contact model.isBlocked in the user list stays false. If I go to Settings/Messaging/Contacts/Blocked, the user is correctly listed there. So it looks like missing some signal propagation

@caybro caybro removed their assignment Dec 13, 2024
@jrainville jrainville self-assigned this Dec 13, 2024
@jrainville jrainville moved this from Next to In Progress in Status Desktop/Mobile Board Dec 17, 2024
@jrainville jrainville mentioned this issue Dec 17, 2024
Merged
2 tasks
jrainville added a commit that referenced this issue Dec 17, 2024
@jrainville
fix(block): fix context menus not updating when blocking/unblocking
ee5a83f 
Fixes #16948
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 17, 2024
jrainville added a commit that referenced this issue Dec 17, 2024
@jrainville
fix(block): fix context menus not updating when blocking/unblocking
b950132 
Fixes #16948
jrainville added a commit that referenced this issue Jan 6, 2025
@jrainville
fix(block): fix context menus not updating when blocking/unblocking
963c51f 
Fixes #16948
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working core-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0 Beta
3 participants
@caybro @jrainville @glitchminer