Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: locally handled methods package base structure #5418

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kounkou
Copy link
Contributor

@kounkou kounkou commented Jun 24, 2024

Description

fixes #5417

Connector service aims at handling eth_ methods received through RPC or WS endpoints. However, some API's must be implemented locally. That's the case for :

  • eth_sendTransaction
  • eth_sign
  • eth_chainId
  • eth_requestAccounts

This PR is created to implement the base structure for implementing those API's. The PR includes implementation for the eth_chainId API.

Important changes:

  • Add local node base structure for eth* calls
  • Add eth_chainId

Test

Tested with Postman that we can query the eth_chainId

{
    "jsonrpc": "2.0",
    "id": 37,
    "result": "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":\"0x1\"}"
}

Screenshot from 2024-06-28 02-30-38

@kounkou kounkou self-assigned this Jun 24, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jun 24, 2024

Jenkins Builds

Click to see older builds (45)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ fa8574c #1 2024-06-24 16:13:56 ~2 min tests 📄log
✔️ fa8574c #1 2024-06-24 16:14:58 ~3 min linux 📦zip
✔️ fa8574c #1 2024-06-24 16:15:08 ~3 min ios 📦zip
✔️ fa8574c #1 2024-06-24 16:16:37 ~5 min android 📦aar
✔️ ac3c79a #2 2024-06-24 16:27:56 ~2 min linux 📦zip
✔️ ac3c79a #2 2024-06-24 16:28:59 ~3 min ios 📦zip
✔️ ac3c79a #2 2024-06-24 16:31:39 ~5 min android 📦aar
✖️ ac3c79a #2 2024-06-24 16:29:00 ~3 min tests 📄log
✔️ f8ae3cf #3 2024-06-24 16:36:19 ~1 min android 📦aar
✔️ f8ae3cf #3 2024-06-24 16:36:56 ~2 min ios 📦zip
✔️ f8ae3cf #3 2024-06-24 16:38:31 ~3 min linux 📦zip
✖️ f8ae3cf #3 2024-06-24 17:16:03 ~41 min tests 📄log
✖️ f8ae3cf #4 2024-06-24 18:21:57 ~39 min tests 📄log
✔️ 1a1ad6d #4 2024-06-24 19:08:56 ~1 min android 📦aar
✔️ 1a1ad6d #4 2024-06-24 19:09:23 ~2 min linux 📦zip
✔️ 1a1ad6d #4 2024-06-24 19:10:06 ~2 min ios 📦zip
✔️ 1a1ad6d #5 2024-06-24 19:47:19 ~40 min tests 📄log
✔️ a6ba877 #5 2024-06-26 16:57:35 ~2 min android 📦aar
✔️ a6ba877 #5 2024-06-26 16:57:44 ~2 min linux 📦zip
✔️ a6ba877 #5 2024-06-26 16:58:02 ~2 min ios 📦zip
✔️ a6ba877 #6 2024-06-26 17:38:20 ~42 min tests 📄log
✖️ f8fbc74 #7 2024-06-27 17:43:56 ~1 min tests 📄log
✔️ f8fbc74 #6 2024-06-27 17:44:26 ~1 min android 📦aar
✔️ f8fbc74 #6 2024-06-27 17:46:31 ~3 min linux 📦zip
✔️ f8fbc74 #6 2024-06-27 17:47:34 ~4 min ios 📦zip
✖️ 5a2a18b #8 2024-06-27 17:48:59 ~1 min tests 📄log
✔️ 5a2a18b #7 2024-06-27 17:49:35 ~2 min android 📦aar
✔️ 5a2a18b #7 2024-06-27 17:49:45 ~2 min linux 📦zip
✔️ 5a2a18b #7 2024-06-27 17:50:48 ~2 min ios 📦zip
✔️ 0eed60a #8 2024-06-27 17:55:43 ~1 min android 📦aar
✔️ 0eed60a #8 2024-06-27 17:57:24 ~3 min ios 📦zip
✔️ 0eed60a #8 2024-06-27 17:58:26 ~4 min linux 📦zip
✔️ 0eed60a #9 2024-06-27 18:36:13 ~41 min tests 📄log
✔️ c61c758 #9 2024-06-27 17:59:46 ~1 min android 📦aar
✔️ c61c758 #9 2024-06-27 18:00:48 ~2 min linux 📦zip
✔️ c61c758 #9 2024-06-27 18:00:50 ~2 min ios 📦zip
✔️ c61c758 #10 2024-06-27 19:17:57 ~41 min tests 📄log
✖️ bc6f667 #11 2024-06-27 21:08:18 ~1 min tests 📄log
✔️ bc6f667 #10 2024-06-27 21:08:36 ~1 min android 📦aar
✔️ bc6f667 #10 2024-06-27 21:09:07 ~2 min linux 📦zip
✔️ bc6f667 #10 2024-06-27 21:09:48 ~2 min ios 📦zip
✔️ ec7f897 #11 2024-06-28 09:18:30 ~2 min linux 📦zip
✔️ ec7f897 #11 2024-06-28 09:18:57 ~2 min ios 📦zip
✔️ ec7f897 #11 2024-06-28 09:21:36 ~5 min android 📦aar
✖️ ec7f897 #12 2024-06-28 09:55:53 ~39 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 41147d7 #12 2024-06-28 09:23:28 ~1 min linux 📦zip
✔️ 41147d7 #12 2024-06-28 09:24:14 ~2 min ios 📦zip
✔️ 41147d7 #12 2024-06-28 09:27:11 ~5 min android 📦aar
✔️ 41147d7 #13 2024-06-28 10:37:22 ~41 min tests 📄log
✔️ 4d33a3b #13 2024-06-28 16:45:41 ~2 min android 📦aar
✔️ 4d33a3b #13 2024-06-28 16:45:58 ~2 min linux 📦zip
✔️ 4d33a3b #13 2024-06-28 16:46:23 ~2 min ios 📦zip
✔️ 4d33a3b #14 2024-06-28 17:24:42 ~41 min tests 📄log

@kounkou kounkou force-pushed the feat-implement-locally-handled-methods branch 3 times, most recently from f8ae3cf to 1a1ad6d Compare June 24, 2024 19:06
@kounkou kounkou force-pushed the feat-implement-locally-handled-methods branch 8 times, most recently from ec7f897 to 41147d7 Compare June 28, 2024 09:21
@kounkou kounkou requested a review from felicio June 28, 2024 09:51
@kounkou kounkou changed the title feat_: Implement locally handled methods feat_: locally handled methods package base structure Jun 28, 2024
@kounkou kounkou force-pushed the feat-implement-locally-handled-methods branch from 41147d7 to 4d33a3b Compare June 28, 2024 16:43
@kounkou kounkou requested a review from cammellos June 28, 2024 16:44
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my perspective, i've already using this changes in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Browser plugin connector service] Implement locally handled API's
3 participants