Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hot reload while theme changing #20563

Open
Parveshdhull opened this issue Jun 25, 2024 · 1 comment
Open

Remove hot reload while theme changing #20563

Parveshdhull opened this issue Jun 25, 2024 · 1 comment

Comments

@Parveshdhull
Copy link
Member

Parveshdhull commented Jun 25, 2024

Summary

For some reason we added hot-reload for debug builds while changing theme.

#19794 (comment)

Most probably we don't need that because release builds are working fine.

Whoever works on this try changing theme while app is open (better using system theme) to see if debug app works fine. Also test overlay, like bottom sheet while testing.

(Ignore status-bar colors, they maybe be broken)

@ilmotta
Copy link
Contributor

ilmotta commented Jun 25, 2024

@Parveshdhull, I'm not working on this issue, but since you asked for people to double-check I'm sharing what I got now: I did a few theme changes from within the app settings with the OS theme in light & dark mode, and all possible combinations, and I didn't see any regressions from removing the hot-reload call. Although I only checked in emulated Android and with API 33, so take it with a grain of salt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants