Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code from old join community flows #20567

Open
ilmotta opened this issue Jun 25, 2024 · 0 comments
Open

Remove code from old join community flows #20567

ilmotta opened this issue Jun 25, 2024 · 0 comments

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Jun 25, 2024

Problem

After we implemented the new join community flow allowing users to select wallet accounts to share, we kept the old implementation behind the feature flag community-accounts-selection-enabled (always set to true in develop). This is an easy source of confusion.

Implementation

The new code is considered stable and has been QAed at the time of implementation and working well for a few months. Therefore, we want to remove all the old code.

Places where you can start (non-exhaustive list):

  • Remove event :communities/request-to-join and other events using it.
  • Remove old unit tests
  • Remove Screen :community-requests-to-join
  • Check namespace status-im.contexts.communities.actions.request-to-join.view
  • Remove the flag community-accounts-selection-enabled?

Acceptance Criteria

Recommended to get the PR through QA, at least as a smoke check.

@ilmotta ilmotta changed the title Clean up code from old join community flows Remove code from old join community flows Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant