Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auth slider resetting when wallet connect signing is finished #20228

Open
clauxx opened this issue May 29, 2024 · 0 comments · May be fixed by #20589
Open

Fix auth slider resetting when wallet connect signing is finished #20228

clauxx opened this issue May 29, 2024 · 0 comments · May be fixed by #20589
Assignees
@alwx
Labels
dapp-interactions-team E:Mobile Bug MVP E:Mobile MVP Wallet Connect refinement Fixing bugs and assuring the quality of the Wallet Connect integration 🔢 low prio
Milestone
2.30.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented May 29, 2024

Bug Report

Problem

Fix the auth slider resetting when the wallet connect signing is finished.

Simulator.Screen.Recording.-.iPhone.13.-.2024-05-29.at.11.03.03.mp4

Expected behavior

The slider stays in place when the modal hides

Actual behavior

The slider moves back when the modal hides

Reproduction

  1. Connect to a dapp via wallet connect (e.g. https://react-app.walletconnect.com/)
  2. Send a signing/transaction request
  3. Slide the auth slider and auth with password or biometrics
  4. Notice the slider resetting when the modal hides

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@clauxx clauxx added dapp-interactions-team E:Mobile Bug MVP E:Mobile MVP Wallet Connect UI Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings labels May 29, 2024
@clauxx clauxx added this to the 2.30.0 Beta milestone May 29, 2024
@clauxx clauxx added E:Mobile Bug MVP E:Mobile MVP Wallet Connect refinement Fixing bugs and assuring the quality of the Wallet Connect integration and removed E:Mobile Bug MVP E:Mobile MVP Wallet Connect UI Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings labels Jun 3, 2024
@alwx alwx self-assigned this Jun 26, 2024
@alwx alwx linked a pull request Jun 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alwx alwx

Labels
dapp-interactions-team E:Mobile Bug MVP E:Mobile MVP Wallet Connect refinement Fixing bugs and assuring the quality of the Wallet Connect integration 🔢 low prio
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

Fix auth slider resetting when wallet connect signing is finished status-im/status-mobile
3 participants
@alwx @churik @clauxx