Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/dcusumkbn2 to follow current project conventions #1473

Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #2020
Closed
3 tasks done

[RFC]: refactor blas/ext/base/dcusumkbn2 to follow current project conventions #1473

Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #2020
Assignees
@vr-varad
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/dcusumkbn2 to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@vr-varad
Copy link
Contributor

Hello @Planeshifter and @kgryte, my last pull requests are currently under review. Can I proceed with working on this issue in the meantime?

@kgryte
Copy link
Member

kgryte commented Mar 24, 2024

@vr-varad Yes, assigned.

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 24, 2024
@vr-varad vr-varad mentioned this issue Mar 24, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Mar 24, 2024
@vr-varad @Planeshifter
refactor: update blas/ext/base/dcusumkbn2 to follow current project…
71a78a5 
… conventions

PR-URL: #2020
Closes: #1473

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vr-varad vr-varad

Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions
3 participants
@Planeshifter @kgryte @vr-varad