Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tapping the carousel previous/next buttons multiple times on iOS devices triggers page zoom #76

Closed
davidjerleke opened this issue Apr 17, 2024 · 0 comments

Comments

@davidjerleke
Copy link

davidjerleke commented Apr 17, 2024

Describe the bug

Hello from the Embla side, I hope you're all doing well 👋!

When tapping the carousel previous and next buttons multiple times on an iOS device, it sometimes triggers an unwanted page zoom.

Suggested solution

I believe adding touch-action: manipulation; to the previous and next buttons solves the problem. As MDN describes it:

Enable panning and pinch zoom gestures, but disable additional non-standard gestures such as double-tap to zoom. Disabling double-tap to zoom removes the need for browsers to delay the generation of click events when the user taps the screen.

Reproduction

  • Browse to the carousel page on an iOS device like an iPhone.
  • Tap on the next button twice or more to scroll through the carousel slides.
  • See the page gets zoomed which probably isn't what you wanted to do.

System Info

Device: iPhone 8
Browser: Safari iOS 16.7.4

Severity

annoyance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants