Some tabs got invisible on tab bar

[wmjordan]

I encountered that some tabs were missing on the tab bar. However, if I hovered the mouse cursor onto it, a tooltip would appear.

I had no idea how this happened.
It might be related to a bug about tab scrolling, when tabs overflowed in the bar.

[Wallby]

For me too in version 2.8.9.3017. Which tabs are shown depends on the size of the unmaximized window, upon maximizing the list of visible tabs doesn't update.

To demonstrate I opened 10 tabs here..

[Wallby]

Tried to track down the cause of this and noticed that DrawItem in TabBar.cpp is indeed not called for the selected tab (in my image "New 10") nor for any of the other tabs (in my image "New 8" and "New 9"). Thus I believe that is entirely the cause why they don't show up, but I am not sure what would be the right fix for it.

I created a patch with the changes I tried, which did seem to correctly track the visibility of the updown control called "spin" and also resulted in no tabs being hidden, but caused some artifacts. Not sure if any of what I tried is useful but sharing it anyway.

0001-Tried-to-fix-invisible-tabs-issue-upon-maximizing-wi.patch

[stefankueng]

Thanks for the patch!
Change committed.

[Wallby]

@stefankueng

It is not a perfect fix for this issue as it introduces new issues, specifically if the window is not maximized and the spin control is visible..

.. and then you maximize the window and then restore it there is a tab that is displayed incorrectly..

.. if you then move one to the right that tab that was displayed incorrectly is displayed correctly again but an artifact stays behind the updown control (right circle around where the artifact is)..

.. which also stays if you go to the last tab..

Also a small note about the commit adc19be.. this else branch for WM_SHOWWINDOW is not required here as WM_SHOWWINDOW was never sent with wParam == TRUE when I tested.

case WM_SHOWWINDOW:
        {
            if (wParam == FALSE) //< checked and is only ever sent with wParam == FALSE
                pTab->m_bIsSpinVisible = false;
            else
                pTab->m_bIsSpinVisible = true;
            break;
        }

[Wallby]

Tried to track down the cause of this and noticed that DrawItem in TabBar.cpp is indeed not called for the selected tab (in my image "New 10") nor for any of the other tabs (in my image "New 8" and "New 9"). Thus I believe that is entirely the cause why they don't show up, but I am not sure what would be the right fix for it.

I meant these two DrawItem calls by the way..

BowPad/src/TabBar.cpp

Line 520 in adc19be

DrawItem(&dis, static_cast<float>(Animator::GetValue(m_animVars[GetIDFromIndex(nTab).GetValue()])));

BowPad/src/TabBar.cpp

Line 541 in adc19be

DrawItem(&dis, static_cast<float>(Animator::GetValue(m_animVars[GetIDFromIndex(nSel).GetValue()])));

[Wallby]

Created a pull request which should fix these artifacts.. #367