Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ListBlockRenderer and ListItemRenderer to respect node settings #12

Closed
stefanzweifel opened this issue Nov 14, 2023 · 0 comments · Fixed by #14
Closed

Rework ListBlockRenderer and ListItemRenderer to respect node settings #12

stefanzweifel opened this issue Nov 14, 2023 · 0 comments · Fixed by #14
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@stefanzweifel
Copy link
Owner

As discussed in #9 and #10, the package currently does a poor job at respecting the various node settings available in the renderer.

We should refactor both ListBlockRenderer and ListItemRenderer to respect the available node settings and support various list types.

- List Item
- Lst Item
* List Item
* List Item
1. List Item
2. List Item
1) List Item
2) List Item

If possible, it would also be great if we could remove our workaround for multi-line list items we've added in #7 that temporarily adds the string _COMMONMARK_MARKDOWN_RENDERER_LINE_BREAK_ to list items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant