Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of root error cause and detailed logging #15

Open
jenkinetics opened this issue Jul 31, 2017 · 2 comments
Open

Lack of root error cause and detailed logging #15

jenkinetics opened this issue Jul 31, 2017 · 2 comments

Comments

@jenkinetics
Copy link

When using Rocket.Chat I found that a (probably valid) SAML Response message leads to an generic "Unable to validate response url: Error: Unknown SAML response message" when coming from an IDP based on pysaml2. The same data from a Shibboleth is successful, although the XML detail vary.

The meteor library should provide the root cause why it believes that the SAML response is "unknown", and the logging should be detailed by providing the the received message as XML or DOM, and a log message after each validation decision and exception.

@jenkinetics
Copy link
Author

Wrt detailed logging: Looking at the source code of the lib I guess that the reason could be that rocket.chat does not set Meteor.settings.debug in its highest log level.

I understand now that "Unknown SAML response message" actually means that it is neither Response not logoutResponse. In this case it would be good to add the message's root element to the error message, or include the full message.

@rhoerbe
Copy link
Contributor

rhoerbe commented Oct 6, 2017

In general the default logging configuration should write messages that when an error condition occurs during Response processing a traceback and internal object representation of the Response is dumped. For common errors a concise message should replace the traceback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants