Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does SEP-24 allow deposits and withdraws to & from unauthenticated accounts? #604

Open
yuriescl opened this issue Mar 20, 2022 · 1 comment
Labels
question Further information is requested

Comments

@yuriescl
Copy link
Contributor

yuriescl commented Mar 20, 2022

I generated a SEP-10 token using an account (not muxed), and then used that SEP-10 token in a SEP-24 deposit call with another account value. It successfully gave me a interactive URL response.
Is this an expected behavior? Shouldn't SEP-24 only allow depositing only to the same account authenticated in SEP-10?

Polaris v2.2.0

@yuriescl yuriescl added the bug Something isn't working label Mar 20, 2022
@JakeUrban
Copy link
Contributor

Hi @yuriescl, this is the expected behavior. It supports the case where the user's funds are held by an account that cannot be used to authenticate via SEP-10.

For example, if a custodial wallet uses Circle or Fireblocks to custody their users' funds, the wallet cannot use the account held by the custody service in SEP-10 because the wallet doesn't have access to the secret key.

In this case, the wallet needs to use a different keypair that they do have access to in SEP-10. This other keypair doesn't need to be funded on the network. However, the actual source of funds will still be the account held by the custody service.

@JakeUrban JakeUrban added question Further information is requested and removed bug Something isn't working labels May 4, 2022
@JakeUrban JakeUrban changed the title SEP-24 allows SEP-10 tokens generated by any account Does SEP-24 allow deposits and withdraws to & from unauthenticated accounts? May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants