Add condition if tx is not success

satyamz · satyamz · commit 873e3fae4093 · 2025-09-18T17:12:28.000+05:30
Signed-off-by: Satyam Zode &lt;satyamz@users.noreply.github.com&gt;
diff --git a/services/friendbot/internal/minion.go b/services/friendbot/internal/minion.go
@@ -96,8 +96,10 @@ func (minion *Minion) Run(ctx context.Context, destAddress string, resultChan ch
 		maybeTransactionSuccess: succ,
 		maybeErr:                errors.Wrapf(err, "submitting tx to minion %x", txHash),
 	}
-	span.SetAttributes(attribute.Bool("minion.tx_success_status", succ.Successful))
-	span.SetStatus(codes.Ok, codes.Ok.String())
+	if succ != nil {
+		span.SetAttributes(attribute.Bool("minion.tx_success_status", succ.Successful))
+		span.SetStatus(codes.Ok, codes.Ok.String())
+	}
 }
 
 // SubmitTransaction should be passed to the Minion.

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,10 @@ func (minion *Minion) Run(ctx context.Context, destAddress string, resultChan ch`
`96`	`96`	`maybeTransactionSuccess: succ,`
`97`	`97`	`maybeErr: errors.Wrapf(err, "submitting tx to minion %x", txHash),`
`98`	`98`	`}`
`99`		`- span.SetAttributes(attribute.Bool("minion.tx_success_status", succ.Successful))`
`100`		`- span.SetStatus(codes.Ok, codes.Ok.String())`
	`99`	`+ if succ != nil {`
	`100`	`+ span.SetAttributes(attribute.Bool("minion.tx_success_status", succ.Successful))`
	`101`	`+ span.SetStatus(codes.Ok, codes.Ok.String())`
	`102`	`+ }`
`101`	`103`	`}`
`102`	`104`
`103`	`105`	`// SubmitTransaction should be passed to the Minion.`