From 3c683b8931e37bced3ecb9b669e624ee492cca30 Mon Sep 17 00:00:00 2001
From: George <Shaptic@users.noreply.github.com>
Date: Mon, 22 May 2023 11:15:09 -0700
Subject: [PATCH] Make builds actually evaluate Typescript type checks...
 (#830)

* Fix SDK to conform to stricter type expectations
---
 config/tsconfig.json         | 3 +--
 package.json                 | 2 +-
 src/server.ts                | 2 +-
 src/stellar_toml_resolver.ts | 2 +-
 src/utils.ts                 | 4 ++--
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/config/tsconfig.json b/config/tsconfig.json
index cb3ca1191..43ff48d73 100644
--- a/config/tsconfig.json
+++ b/config/tsconfig.json
@@ -3,11 +3,10 @@
   "compilerOptions": {
     "declaration": true,
     "declarationDir": "../lib",
-    "lib": ["es2015"],
     "moduleResolution": "node",
     "rootDir": "../src",
     "outDir": "../lib",
-    "target": "es5"
+    "target": "es6"
   },
   "include": ["../src"]
 }
diff --git a/package.json b/package.json
index 87a5c5df3..70fe5aa55 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
   "scripts": {
     "build": "cross-env NODE_ENV=development yarn _build",
     "build:prod": "cross-env NODE_ENV=production yarn _build",
-    "build:node": "babel --extensions '.ts' --out-dir lib/ src/",
+    "build:node": "babel --extensions '.ts' --out-dir lib/ src/ && tsc -p ./config/tsconfig.json",
     "build:browser": "webpack --stats-modules-space 999 -c config/webpack.config.browser.js",
     "clean": "rm -rf lib/ dist/ coverage/ .nyc_output/",
     "docs": "jsdoc -c ./config/.jsdoc.json --verbose",
diff --git a/src/server.ts b/src/server.ts
index d4ffa6a52..70f384388 100644
--- a/src/server.ts
+++ b/src/server.ts
@@ -81,7 +81,7 @@ export class Server {
         ? Config.isAllowHttp()
         : opts.allowHttp;
 
-    const customHeaders: object = {};
+    const customHeaders: Record<string, string> = {};
 
     if (opts.appName) {
       customHeaders["X-App-Name"] = opts.appName;
diff --git a/src/stellar_toml_resolver.ts b/src/stellar_toml_resolver.ts
index 9bb0f22bf..181734daf 100644
--- a/src/stellar_toml_resolver.ts
+++ b/src/stellar_toml_resolver.ts
@@ -63,7 +63,7 @@ export class StellarTomlResolver {
         try {
           const tomlObject = toml.parse(response.data);
           return Promise.resolve(tomlObject);
-        } catch (e) {
+        } catch (e: any) {
           return Promise.reject(
             new Error(
               `stellar.toml is invalid - Parsing error on line ${e.line}, column ${e.column}: ${e.message}`,
diff --git a/src/utils.ts b/src/utils.ts
index 72105cd45..2a99b4a97 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -509,7 +509,7 @@ export namespace Utils {
     let serverKP: Keypair;
     try {
       serverKP = Keypair.fromPublicKey(serverAccountID); // can throw 'Invalid Stellar public key'
-    } catch (err) {
+    } catch (err: any) {
       throw new Error(
         "Couldn't infer keypair from the provided 'serverAccountID': " +
           err.message,
@@ -686,7 +686,7 @@ export namespace Utils {
       let keypair: Keypair;
       try {
         keypair = Keypair.fromPublicKey(signer); // This can throw a few different errors
-      } catch (err) {
+      } catch (err: any) {
         throw new InvalidSep10ChallengeError(
           "Signer is not a valid address: " + err.message,
         );