From b5eac57470d8210efdb5df75bb56224e8b82cfe7 Mon Sep 17 00:00:00 2001 From: George Date: Tue, 18 Jul 2023 13:16:24 -0700 Subject: [PATCH] Make Node 16 the minimum version. (#847) * Bump babel compilation target --- .github/workflows/gh_pages.yaml | 4 ++-- .github/workflows/npm_publish.yml | 2 +- .github/workflows/tests.yml | 2 +- README.md | 6 +++--- babel.config.json | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/gh_pages.yaml b/.github/workflows/gh_pages.yaml index 6d0280e04..6179b1d0f 100644 --- a/.github/workflows/gh_pages.yaml +++ b/.github/workflows/gh_pages.yaml @@ -18,10 +18,10 @@ jobs: repository: stellar/js-stellar-base path: js-stellar-base - - name: Install Node (14.x) + - name: Install Node (16.x) uses: actions/setup-node@v3 with: - node-version: '14.x' + node-version: 16 - name: Install Dependencies run: yarn install diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index 8c808d87d..0a72ea4d1 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -13,7 +13,7 @@ jobs: - name: Install Node uses: actions/setup-node@v3 with: - node-version: '14.x' + node-version: 16 registry-url: 'https://registry.npmjs.org' - name: Install Depencencies diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3d33badb7..514f4173f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,7 +13,7 @@ jobs: fail-fast: false max-parallel: 4 matrix: - node-version: [14, 16, 18] + node-version: [16, 18, 20] steps: - name: Checkout diff --git a/README.md b/README.md index 467d71da7..7e638618e 100644 --- a/README.md +++ b/README.md @@ -134,16 +134,16 @@ cd js-stellar-sdk npm install ``` -3. Install Node 14 +3. Install Node 16 -Because we support the oldest maintenance version of Node, please install and develop on Node 14 so you don't get surprised when your code works locally but breaks in CI. +Because we support the oldest maintenance version of Node, please install and develop on Node 16 so you don't get surprised when your code works locally but breaks in CI. Here's how to install `nvm` if you haven't: https://github.com/creationix/nvm ```shell nvm install -# if you've never installed 14 before you'll want to re-install yarn +# if you've never installed 16 before you'll want to re-install yarn npm install -g yarn ``` diff --git a/babel.config.json b/babel.config.json index be37815c0..ddf498d1b 100644 --- a/babel.config.json +++ b/babel.config.json @@ -14,7 +14,7 @@ "production": { "comments": false, "targets": { - "node": 14, + "node": 16, "browsers": [ "> 2%", "ie 11",