Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native test contract frames actually could do relative object translation #1286

Open
graydon opened this issue Dec 3, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@graydon
Copy link
Contributor

graydon commented Dec 3, 2023

Currently native test contracts don't do relative-to-absolute object handle translation the way VM frames do. In this way they lack a degree of fidelity with VM frames. When I initially implemented it I somehow forgot there actually is a central place we could do this, in the impl <T:VmCallerEnv> Env for T macro-generated impl in vmcaller_env.rs in common.

This is not a security issue nor a breaking change for any contracts in the wild. It would change the observable semantics of a small part of test contracts that you really shouldn't be looking at anyways (object numbers) while improving fidelity between VM and native testing (in terms of cost model accuracy and object numbers in case you were looking). So we should probably do it at some point in the future. But it doesn't have to happen right now.

@graydon graydon added the bug Something isn't working label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@graydon and others