-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BL12-381 Integration #1310
base: main
Are you sure you want to change the base?
BL12-381 Integration #1310
Conversation
Some general comments. I'm not too familiar with the implementation details yet. None of these functions can use existing metering cost types, for each of these functions {p1, p2}_{add, mul, serialize}, a new cost types need to be added, calibrated and charged. |
Besides the points that @jayz22 has mentioned, there are important high-level issues:
I suppose this PR could be used as a starting point for the future work, but we can't really merge it until these issues have been resolved. |
Ok I think I know what needs to be done to the PR to make it review ready. Will convert to draft in the meantime |
9a6a7b3
to
4560f55
Compare
Ready for review in terms of the implementation. Still requires adding budgeting of individual operations and charging them in stellar-xdr |
269b2ec
to
6a85e35
Compare
What
Added:
Missing:
Why
Because of issue #779
Known limitations