Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use panic_with_error instead of panic in the token spec #844

Closed
sisuresh opened this issue Jan 27, 2023 · 1 comment
Closed

Use panic_with_error instead of panic in the token spec #844

sisuresh opened this issue Jan 27, 2023 · 1 comment

Comments

@sisuresh
Copy link
Contributor

Related to stellar/soroban-examples#199.

The token spec is meant to be use to generate a token client to call into token contract that implements the token spec. If a user uploads the token spec and tries to call into it, the contract will panic! with an error message, but that message won't propagate up because it isn't using panic_with_error!, making a simple bug difficult to debug.
@leighmcculloch
Copy link
Member

We deprecated the token spec crate, so I think we can close this now.

@leighmcculloch leighmcculloch closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leighmcculloch @sisuresh