Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-example-dapp: add support for fees #107

Closed
tsachiherman opened this issue May 3, 2023 · 2 comments · Fixed by #105
Closed

soroban-example-dapp: add support for fees #107

tsachiherman opened this issue May 3, 2023 · 2 comments · Fixed by #105
Assignees
Labels
preview-9 soroban-scrum A label to make relevant issues appear in the Platform Scrum board.

Comments

@tsachiherman
Copy link

What ?

Add support for fees

Epic

stellar/stellar-cli#519

@tsachiherman tsachiherman added the soroban-scrum A label to make relevant issues appear in the Platform Scrum board. label May 3, 2023
@sreuland
Copy link
Contributor

@tsachiherman , I think the changes for simulation data on js-soroban-client #77 are shaping up to be backwards compatible with the current dapp, as dapp submits tx with classic fee(via soroban-react lib) to soroban-client::prepareTransaction which hasn't had an interface change, under the hood it applies the new SorobanTransactionData,Auth, Fees from simulation onto the user's tx. It appends the new fee onto existing classic fee for final tx fee. So, end result would be same UX flow from pledge button to freighter wallet popup display to then updated pledged amounts.

the scope here doesn't mention ux changes, so, if this silent final fee flow is ok then the scope here should be pretty limited to just updating the version ref to js-soroban-client.

we can do additional changes to show new UX activity like a user dialog popup with a confirm for the fees, but that could be addressed in a post-release feature if you agree.

@tsachiherman
Copy link
Author

@tsachiherman , I think the changes for simulation data on js-soroban-client #77 are shaping up to be backwards compatible with the current dapp, as dapp submits tx with classic fee(via soroban-react lib) to soroban-client::prepareTransaction which hasn't had an interface change, under the hood it applies the new SorobanTransactionData,Auth, Fees from simulation onto the user's tx. It appends the new fee onto existing classic fee for final tx fee. So, end result would be same UX flow from pledge button to freighter wallet popup display to then updated pledged amounts.

the scope here doesn't mention ux changes, so, if this silent final fee flow is ok then the scope here should be pretty limited to just updating the version ref to js-soroban-client.

we can do additional changes to show new UX activity like a user dialog popup with a confirm for the fees, but that could be addressed in a post-release feature if you agree.

It's ok that we don't add any UI to iterate not the fees selection, but we still need to add a in-code comment where that functionality would be implemented.

Also, this is the first place where we can actually test that these calculated fees truly work.. so we shouldn't close this ticket before validating the end-to-end functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-9 soroban-scrum A label to make relevant issues appear in the Platform Scrum board.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants