Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide initialize.sh option to a remote rpc #113

Closed
sreuland opened this issue Jun 2, 2023 · 3 comments · Fixed by #114
Closed

Provide initialize.sh option to a remote rpc #113

sreuland opened this issue Jun 2, 2023 · 3 comments · Fixed by #114

Comments

@sreuland
Copy link
Contributor

sreuland commented Jun 2, 2023

What problem does your feature solve?

./initialize.sh futurenet defaults to rpc on localhost url

What would you like to see?

./initialize.sh futurenet <optional_rpc_url>

such as

./initialize.sh futurenet https://rpc-futurenet.stellar.org:443

What alternatives are there?

do the same commands as initialize.sh and save results manually in local .soroban-example-dapp
@chadoh
Copy link
Contributor

chadoh commented Jun 2, 2023

Would it be worth having ./initialize.sh futurenet use remote RPC URL by default, with fallback option for localhost? Or maybe even always use remote?

@sreuland
Copy link
Contributor Author

sreuland commented Jun 2, 2023

that default sounds more idiomatic for futurenet reference, and can still retain ability to override that with a custom url seems flexible enough, unless anyone has objections?

@chadoh
Copy link
Contributor

chadoh commented Jun 2, 2023

implementing it now; PR soon

chadoh added a commit to AhaLabs/soroban-example-dapp that referenced this issue Jun 2, 2023
@chadoh
feat: default 'futurenet' to use remote rpc url
8e1678e 
Fixes stellar#113

When `./initialize.sh futurenet` is used, default to using a remote RPC
URL rather than the local Docker node.
@chadoh chadoh mentioned this issue Jun 2, 2023
Merged
chadoh added a commit to AhaLabs/soroban-example-dapp that referenced this issue Jun 2, 2023
@chadoh
feat: default 'futurenet' to use remote rpc url
4eed628 
Fixes stellar#113

When `./initialize.sh futurenet` is used, default to using a remote RPC
URL rather than the local Docker node.
paulbellamy pushed a commit that referenced this issue Jun 6, 2023
@chadoh
feat: default 'futurenet' to use remote rpc url (#114)
f4f90a8 
Fixes #113

When `./initialize.sh futurenet` is used, default to using a remote RPC
URL rather than the local Docker node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: default 'futurenet' to use remote rpc url AhaLabs/soroban-example-dapp
2 participants
@chadoh @sreuland