Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use provideWalletChains anymore #82

Closed
esteblock opened this issue Jan 11, 2023 · 1 comment
Closed

Don't use provideWalletChains anymore #82

esteblock opened this issue Jan 11, 2023 · 1 comment

Comments

@esteblock
Copy link
Contributor

esteblock commented Jan 11, 2023

What problem does your feature solve?

Functions and variables defined in wallet/provideWalletChains,tsx are confusing.
At the end it does only add a iconBackground parameter to each chain.

What would you like to see?

We could avoid this either:

  • not using the iconBackground" parameter,
  • setting the iconBackground parameter in the @soroban-react/chains library
  • setting localy the iconBackground parameter in a more elegant way
setIconBacground(chain){
if (chain == chain1) return background1
else if (chain == chain2) return backgorund2
.
.
.

@esteblock esteblock changed the title Don't use anymore provideWalletChains Don't use provideWalletChains anymore Jan 11, 2023
@esteblock
Copy link
Contributor Author

Solved in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants