Refactor ApplyBuckets Work #4290
Assignees
Labels
cleanup
refactoring or other internal improvements
Comments
6 tasks
6 tasks
SirTyson
added a commit
to ThomasBrady/stellar-core
that referenced
this issue
Jul 1, 2024
# Description Refactors `ApplyBucketsWork` to apply buckets per-bucket rather than per-level. Deleted a lot of book keeping code referring to curr/snap apply ordering. Issue: stellar#4290 <!--- Describe what this pull request does, which issue it's resolving (usually applicable for code changes). ---> # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [ ] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Currently,
ApplyBucketswork reasons at theBucketLevelinstead of at the per-bucket level. Especially after the BucketListDB apply optimization, this means that there's some tricky logic required to keep our current place in the BucketList and make sure our iteration order is correct. We should refactor this to apply per-bucket instead of per-level to simplify the logic.The text was updated successfully, but these errors were encountered: